From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Wed, 25 Feb 2004 16:31:53 +0000 Subject: Re: [PATCH] allow non-block devices for udevinfo Message-Id: <1077726712.1161.20.camel@pim> List-Id: References: <403CACFA.8080308@suse.de> In-Reply-To: <403CACFA.8080308@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, 2004-02-25 at 15:11, Hannes Reinecke wrote: > Hi all, > > with the attached patch to udevinfo it is possible to look also at > devices in /class which do not provide the 'dev' attribute, e.g. net > devices. > Agreed, it is of limited usefulness as it stands, but with it we can > check devices for consistency with the 'standard' or 'acceptable' > behaviour re. sysfs. And complain loudly to the driver maintainer if > they don't (Hi Arnd !). I don't think, that we should print udev keys for devices that udev can't handle. It claims that the printed keys are usable in a rule. I agree that we should check the standard compliance as much as we can, but I don't think that's the goal of udevinfo. Remember that all multiline values and values containing nonprintable chars are simply skipped in the current udevinfo device walk. So nonconformant attributes are as well not printed. If you really need it, please make it a separate tool or at least a different command line option of udevinfo. Please don't print any attribute we can't use, in the SYSFS{attribute} format. I expect a lot of legitimate confusion otherwise. thanks, Kay ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id56&alloc_id438&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel