From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Wed, 25 Feb 2004 22:49:44 +0000 Subject: Re: Excess spaces in sysfs files Message-Id: <1077749384.3224.22.camel@pim> List-Id: References: <403D12BC.40209@reactivated.net> In-Reply-To: <403D12BC.40209@reactivated.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, 2004-02-25 at 22:25, Daniel Drake wrote: > 1. Should these spaces be here? Are devices really identifying themselves with > spaces on the end? Or is this an issue with sysfs/similar. It's common. Seems like vendors are just filling fixed length fields. A lot of fields are 8 characters total length. > 2. Should udev trim whitespace from the end of SYSFS{..} values (files), so > that keys such as > SYSFS{model} = "iPod" > would match a file containing > "iPod " > > If the above behaviour is implemented, I would suggest having a second key > type, SYSFS_RAW{..} where whitespace is not trimmed. I am prepared to write a > patch for this. Hey, udevinfo is so cute :) I don't like the idea to try to be smart with the matching, but if we really want this, I prefer to have it configurable in the config file. thanks, Kay ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id56&alloc_id438&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel