linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Love <rml@ximian.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [patch] automatically install correct initscript
Date: Tue, 02 Mar 2004 01:08:32 +0000	[thread overview]
Message-ID: <1078189712.10733.50.camel@localhost> (raw)
In-Reply-To: <1078188416.10733.44.camel@localhost>

On Mon, 2004-03-01 at 20:04, Kay Sievers wrote:

> Seems that line 380 of the Makefile doesn't play with you :)

Ack, I did not even see that!  Thanks.

Let's rip that out, and always use the new built-in logic to determine
what initscript to install.

	Robert Love


 Makefile |   17 ++++++++++-------
 TODO     |    1 -
 2 files changed, 10 insertions(+), 8 deletions(-)

diff -urN udev-019/Makefile udev/Makefile
--- udev-019/Makefile	2004-02-27 20:11:47.000000000 -0500
+++ udev/Makefile	2004-03-01 20:07:20.509296424 -0500
@@ -341,6 +341,15 @@
 	-
 endif
 
+install-initscript: etc/init.d/udev etc/init.d/udev.debian etc/init.d/udev.init.LSB
+	@if [ -f /etc/redhat-release ]; then \
+		$(INSTALL_DATA) etc/init.d/udev $(etcdir)/init.d/udev; \
+	elif [ -f /etc/SuSE-release ]; then \
+		$(INSTALL_DATA) etc/init.d/udev.init.LSB $(etcdir)/init.d/udev; \
+	elif [ -f /etc/debian_version ]; then \
+		$(INSTALL_DATA) etc/init.d/udev.debian $(etcdir)/init.d/udev; \
+	fi
+
 install-config: $(GEN_CONFIGS)
 	$(INSTALL) -d $(DESTDIR)$(configdir)
 	@if [ ! -r $(DESTDIR)$(configdir)udev.conf ]; then \
@@ -356,7 +365,7 @@
 		$(INSTALL_DATA) $(LOCAL_CFG_DIR)/udev.permissions $(DESTDIR)$(configdir); \
 	fi
 
-install: install-config install-dbus-policy all
+install: install-initscript install-config install-dbus-policy all
 	$(INSTALL) -d $(DESTDIR)$(udevdir)
 	$(INSTALL) -d $(DESTDIR)$(hotplugdir)
 	$(INSTALL_PROGRAM) -D $(ROOT) $(DESTDIR)$(sbindir)/$(ROOT)
@@ -364,12 +373,6 @@
 	$(INSTALL_PROGRAM) -D $(SENDER) $(DESTDIR)$(sbindir)/$(SENDER)
 	$(INSTALL_PROGRAM) -D $(HELPER) $(DESTDIR)$(sbindir)/$(HELPER)
 	$(INSTALL_PROGRAM) -D $(TESTER) $(DESTDIR)$(sbindir)/$(TESTER)
-	@if [ "x$(USE_LSB)" = "xtrue" ]; then \
-		$(INSTALL_PROGRAM) -D etc/init.d/udev.init.LSB $(DESTDIR)$(initdir)/udev; \
-		ln -s $(DESTDIR)$(initdir)/udev $(sbindir)/rcudev; \
-	else \
-		$(INSTALL_PROGRAM) -D etc/init.d/udev $(DESTDIR)$(initdir)/udev; \
-	fi
 	$(INSTALL_DATA) -D udev.8 $(DESTDIR)$(mandir)/man8/udev.8
 	$(INSTALL_DATA) -D udevinfo.8 $(DESTDIR)$(mandir)/man8/udevinfo.8
 	$(INSTALL_DATA) -D udevd.8 $(DESTDIR)$(mandir)/man8/udevd.8
diff -urN udev-019/TODO udev/TODO
--- udev-019/TODO	2004-03-01 19:44:47.457991488 -0500
+++ udev/TODO	2004-03-01 19:44:38.682325592 -0500
@@ -7,7 +7,6 @@
 
 
 - more documentation (can never have too much.)
-- install the proper init.d script based on the distro we are running on.
 - persuade the distro packagers to submit their changes (or just steal them
   if we can find them...)
 - create kernel name to devfs name config file so that all of the devfs users




-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  parent reply	other threads:[~2004-03-02  1:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-02  0:46 [patch] automatically install correct initscript Robert Love
2004-03-02  1:04 ` Kay Sievers
2004-03-02  1:08 ` Robert Love [this message]
2004-03-02  1:14 ` Kay Sievers
2004-03-02  1:23 ` Robert Love
2004-03-02 20:28 ` Greg KH
2004-03-03 18:46 ` Chris Larson
2004-03-03 19:10 ` Greg KH
2004-03-03 19:21 ` Chris Larson
2004-03-03 19:36 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1078189712.10733.50.camel@localhost \
    --to=rml@ximian.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).