Re: [PATCH] cleanup udevstart

[Kay Sievers <kay.sievers@vrfy.org>]

On Tue, 2004-03-16 at 18:01, Patrick Mansfield wrote:
> On Tue, Mar 16, 2004 at 03:49:51AM +0100, Kay Sievers wrote:
> > 
> > Here are all fgets() converted to mmap(), also the config file read.
> > I get for a very small(20 lines) rules file:
> > 
> >   time ./udevstart
> 
> My timings using lots of scsi_debug LUN's and 1000 line udev.rules got a
> about twice the speedup for klibc compared to your timings (almost 6 times
> faster). None of my udev.rules match, so all 1000 rules are compared even
> for 512 LUNs.

Hey, looks like a pretty nice speedup.

> The inlines of longer functions gains nothing (and probably the other
> inlines in udev.h that are more than 2 lines long and use more than once).
> Not inlining file_map and buf_get_line gives almost no difference in
> times, but shrinks executables a bit.

Yes, I know. It was just a quick hack. I tried to avoid putting "normal"
functions into a header file. If we want this to go in, we may create a
udev_lib.[hc] or something and put in all the generic stuff currently in
udev.h.

> insmod was really this:
> 
> 	modprobe scsi_debug num_tgts2 max_luns\x16 delay=0
> 
> Total elapsed times as follows:
> 
> 			insmod		rmmod
> klibc current		4:11.42		4:06.27
> klibc patch		0:38.48		0:30.89
> klibc noinline 		0:38.33		0:30.89
> glibc current		0:40.84		0:36.20
> glibc with patch	0:40.72		0:32.41

Much thanks for your measurements. It's always better to have real
numbers :)
It seeems that we need to fix it. The mmap() difference for glibc is
pretty small, so it should also be possible to fix the fgets() in klibc.
Any suggestion to go with mmap() or fix klibc instead?

thanks again,
Kay




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel