Re: Patch to multipath-tools 0.2.4

[christophe.varoqui@free.fr]

Thanks,

merged in multipath-tools-0.2.5
it works here on StorageWorks :

xa-s03:~/multipath/multipath-tools-0.2.5/multipath# ./multipath -v
/dev/sda: ID descriptor at 4:
/dev/sda: Association: 0
/dev/sda: Codeset: 1
/dev/sda: ID type: NAA IEEE Registered Extended
/dev/sda: binary 600508b4000156d700012000000b0000 (len 20)
/dev/sdb: ID descriptor at 4:
/dev/sdb: Association: 0
/dev/sdb: Codeset: 1
/dev/sdb: ID type: NAA IEEE Registered Extended
/dev/sdb: binary 600508b4000156d700012000000b0000 (len 20)
# all paths :
600508b4000156d700012000000b0000 (3 0 0 1) /dev/sda [HSV110 (C)COMPAQ]
600508b4000156d700012000000b0000 (3 0 1 1) /dev/sdb [HSV110 (C)COMPAQ]
# all multipaths :
600508b4000156d700012000000b0000
 \_(3 0 0 1) /dev/sda [HSV110 (C)COMPAQ]
 \_(3 0 1 1) /dev/sdb [HSV110 (C)COMPAQ]
# device maps :
U:600508b4000156d700012000000b0000:0 62914560 multipath 2 round-robin 1 0
/dev/sda round-robin 1 0 /dev/sdb


If you want the IBM ESS strings in the default config file and core defaults,
please send the corresponding patch.

regards,
cvaroqui

Selon Hannes Reinecke <hare@suse.de>:

> Hi Christophe,
> 
> I've made a patch to multipath-tools 0.2.4 to correctly decipher SCSI 
> EVPD page 0x83. The current code is totally ignorant of the fact that 
> EVPD page 0x83 can return more than one identifier, some of which are 
> either bogus (i.e. containing an empty string) or should be preferred to 
> the other identifiers.
> 
> The attached patch
> - correctly deciphers EVPD page 0x83
> - Tries to select the 'best' candidate if several IDs are returned:
>    - ID should not be empty (i.e. either only spaces or Nulls)
>    - Order of preference:
> 	- NAA (hightest subtype is preferrred)
> 	- EUI-64
> 	- T-10
> 	- Vendor specific
> - Map spaces to underscores if the serial number is ASCII; this is 	
>    mainly to generate valid mapping names.
> 
> Would be great if this patch could be included, as without this the 
> multipath tools do not work correctly with the IBM ESS.
> 
> Most of the decoding logic is in fact stolen from scsi_id (thanks 
> Patrick), so we should probably add a copyright statement somewhere.
> 
> We should actually be using the scsi_id package directly as this would 
> give us identical mappings for udev and multipath tools. But as this 
> would mean a major restructuring of the program itself I took the cheap 
> way out. Patrick, can you think of a clever way of integrating both?
> 
> Cheers,
> 
> Hannes
> -- 
> Dr. Hannes Reinecke			hare@suse.de
> SuSE Linux AG				S390 & zSeries
> Maxfeldstraße 5				+49 911 74053 688
> 90409 Nürnberg				http://www.suse.de
> 


-- 


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel