From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] udev - read long lines from config files overflow fix
Date: Sun, 05 Sep 2004 18:51:10 +0000 [thread overview]
Message-ID: <1094410271.24196.16.camel@localhost.localdomain> (raw)
In-Reply-To: <20040904170854.GA12270@spock.enterprise>
On Mon, 2004-09-06 at 02:28 +0800, Arun Bhanu wrote:
> On 23:12 Sat 04 Sep , Kay Sievers wrote:
> > Cool, a real bug :)
> > Thanks, for the patch. I think it would be better to skip lenghth exceeding
> > lines instead of cutting it and continue. While looking at it I restructured
> > the buffer reading logic a bit and fixed another stupid bug.
> Thanks for the cleanup.
>
> You may have overlooked the fix for udev_config.c(parsing udev.conf) in
> your patch. So, I've adapted the fixes you applied to namedev_parse.c
> to this file also.
>
> Also, while 'eating' the whitespace the 'count' doesn't get decremented.
> This leads strncpy to copy the number of whitespace minus 1 characters
> from the next line. Minus 1 because it copies '\n' from the current
> line.
Huh, bad. Yeah, missed the first and broke the second, hope
nobody will drive a airplane with this software :)
Looks good, your patch! Many thanks,
Kay
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idP47&alloc_id\x10808&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-09-05 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-04 17:08 [PATCH] udev - read long lines from config files overflow fix Arun Bhanu
2004-09-04 21:12 ` Kay Sievers
2004-09-05 18:28 ` Arun Bhanu
2004-09-05 18:51 ` Kay Sievers [this message]
2004-09-10 20:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094410271.24196.16.camel@localhost.localdomain \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).