From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Sun, 05 Sep 2004 18:51:10 +0000 Subject: Re: [PATCH] udev - read long lines from config files overflow fix Message-Id: <1094410271.24196.16.camel@localhost.localdomain> List-Id: References: <20040904170854.GA12270@spock.enterprise> In-Reply-To: <20040904170854.GA12270@spock.enterprise> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Mon, 2004-09-06 at 02:28 +0800, Arun Bhanu wrote: > On 23:12 Sat 04 Sep , Kay Sievers wrote: > > Cool, a real bug :) > > Thanks, for the patch. I think it would be better to skip lenghth exceeding > > lines instead of cutting it and continue. While looking at it I restructured > > the buffer reading logic a bit and fixed another stupid bug. > Thanks for the cleanup. > > You may have overlooked the fix for udev_config.c(parsing udev.conf) in > your patch. So, I've adapted the fixes you applied to namedev_parse.c > to this file also. > > Also, while 'eating' the whitespace the 'count' doesn't get decremented. > This leads strncpy to copy the number of whitespace minus 1 characters > from the next line. Minus 1 because it copies '\n' from the current > line. Huh, bad. Yeah, missed the first and broke the second, hope nobody will drive a airplane with this software :) Looks good, your patch! Many thanks, Kay ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_idP47&alloc_id808&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel