linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [patch] Fix naming ethernet devices in udevstart
Date: Tue, 07 Sep 2004 10:46:43 +0000	[thread overview]
Message-ID: <1094554003.4146.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20040907031839.GA20951@smtp.west.cox.net>

On Mon, 2004-09-06 at 20:18 -0700, Tom Rini wrote:
> I noticed somewhat recently that my enet devices weren't being renamed
> on boot anymore.  I don't quite know when this got broken (or rather, if
> it was supposed to be working.  I swear it worked for me once..), but
> the following seems to do it.

I think it never worked in the udevstart case. It worked only with the
hotplug-event-udev, I expect.

> In udev_scan_class(), look for not just
> %s/%s/dev (which everything with a dev node has), but %s/%s/dev* (both
> of my enet devices, sis900 & 3c59x only have device) and if that
> exists, pass this along to udev.

Yeah, network devices don't have a devnode and therefore no "dev", but
they are all in /sys/class/net/. We may just test if we are there
instead of the "device" match.
Btw: Greg, what's the reason not to use libsysfs for the directory walk?

> This does mean that other things
> which udev doesn't know how to handle
> (/sys/class/usb_host/usb%d/device) will get passed along, but I don't
> know of a bitter solution.  Tested on my Debian/unstable machine.
             ^
Yeah, nice typo :)

Best,
Kay



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idP47&alloc_id\x10808&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  reply	other threads:[~2004-09-07 10:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-07  3:18 [patch] Fix naming ethernet devices in udevstart Tom Rini
2004-09-07 10:46 ` Kay Sievers [this message]
2004-09-07 16:56 ` Kay Sievers
2004-09-07 17:23 ` Tom Rini
2004-09-07 22:54 ` Tom Rini
2004-09-10 20:19 ` Greg KH
2004-09-10 20:21 ` Greg KH
2004-09-10 21:25 ` Kevin P. Fleming
2004-09-10 23:00 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094554003.4146.23.camel@localhost.localdomain \
    --to=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).