Re: Problems using scsi_id with udevstart

[Andrew Patterson <andrew.patterson@hp.com>]

[-- Attachment #1: Type: text/plain, Size: 3308 bytes --]

On Wed, 2004-10-06 at 18:44 +0200, Kay Sievers wrote:
> On Wed, Oct 06, 2004 at 10:20:56AM -0600, Andrew Patterson wrote:
> > On Wed, 2004-10-06 at 01:55 +0200, Kay Sievers wrote:
> > > On Tue, Oct 05, 2004 at 05:33:46PM -0600, Andrew Patterson wrote:
> > > > Hi,
> > > > 
> > > > I added the following udev rule to make human-readable device file names
> > > > for my SCSI disks:
> > > > 
> > > > BUS="scsi", KERNEL="sd*", PROGRAM="scsi_id", NAME="scsi_disks/%c-%b", SYMLINK="%k"
> > >                                      ^^^^^^^
> > > 
> > > You need an absolute path here to properly call the binary.
> > 
> > Correct, too much cut an pasting.  It still doesn't work even with the
> > correct path.  Here is the output using /sbin/scsi_id:
> > 
> > namedev_name_device: sysfs_device->bus='scsi'
> > wait_for_device_to_initialize: looking for file 'vendor' on bus 'scsi'
> > namedev_name_device: class_dev->name = 'sda'
> > namedev_name_device: udev->kernel_name = 'sda'
> > namedev_name_device: kernel_number=''
> > namedev_name_device: process rule
> > match_rule: check for BUS dev->bus='scsi' sysfs_device->bus='scsi'
> > match_rule: BUS matches
> > match_rule: check for KERNEL dev->kernel='sd*' class_dev->name='sda'
> > match_rule: KERNEL matches
> > match_rule: check PROGRAM
> > execute_program: path = /sbin/scsi_id
> > 
> > execute_program: result is ''
> > execute_program: exec program status 0x100
> > match_rule: PROGRAM returned nonzero
> > match_rule: try parent sysfs device
> 
> Where is the "path = /sbin/scsi_id" line coming from? Other lines are missing.
> Did you change anything in the code. It should look more like this:
> 

Yep, added some debugging code.  Here are the diff's:

diff -Nur udev-032/namedev.c udev-032.new/namedev.c
--- udev-032/namedev.c  2004-09-13 23:55:36.000000000 -0600
+++ udev-032.new/namedev.c      2004-10-05 17:09:08.000000000 -0600
@@ -423,6 +423,8 @@
        char arg[PROGRAM_SIZE];
        char *argv[sizeof(arg) / 2];
        int i;
+
+       dbg("path = %s\n", path);

        i = 0;
        if (strchr(path, ' ')) {
diff -Nur udev-032/udev.c udev-032.new/udev.c
--- udev-032/udev.c     2004-09-13 23:55:32.000000000 -0600
+++ udev-032.new/udev.c 2004-10-05 16:58:37.000000000 -0600
@@ -50,8 +50,10 @@
                return;

        va_start(args, format);
-       vsyslog(level, format, args);
+//     vsyslog(level, format, args);
+       vprintf(format, args);
        va_end(args);
+       printf("\n");
 }
 #endif


Here is the compile line I used:

$ make  USE_LOG=true DEBUG=true

>   udev[25565]: match_rule: KERNEL matches
>   udev[25565]: match_rule: check PROGRAM
>   udev[25565]: execute_program: execute '/bin/false' with main argument
>   udev[25565]: execute_program: result is ''
>   udev[25565]: execute_program: exec program status 0x100
>   udev[25565]: match_rule: PROGRAM returned nonzero
>   udev[25565]: match_rule: try parent sysfs device
> 
> And please try to run scsi_id on the commandline if it works there.
> 

# /sbin/scsi_id 
-s must be specified

# /sbin/scsi_id -s /block/sda
2000c50fffe33f611

The -g option was added in /etc/scsi_id.cong

> Kay
> 

Andrew

-- 
Andrew Patterson                
Hewlett-Packard

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]