From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Patterson Date: Tue, 12 Oct 2004 23:04:21 +0000 Subject: Re: Problem parsing %s in udev rules Message-Id: <1097622262.13758.56.camel@bluto.andrew> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-3gt5YkB6jAYEYUIIJd+U" List-Id: References: <1097105584.9273.9.camel@bluto.andrew> In-Reply-To: <1097105584.9273.9.camel@bluto.andrew> To: linux-hotplug@vger.kernel.org --=-3gt5YkB6jAYEYUIIJd+U Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kay, On Thu, 2004-10-07 at 02:30 +0200, Kay Sievers wrote: > On Wed, Oct 06, 2004 at 06:23:05PM -0600, Andrew Patterson wrote: > > On Thu, 2004-10-07 at 01:50 +0200, Kay Sievers wrote: > > > On Wed, Oct 06, 2004 at 05:33:04PM -0600, Andrew Patterson wrote: > > > > Udev seems to be chopping off anything seen in a rule after a %s. = For > > > > example, if I have the following rule: > > > >=20 > > > > BUS=3D"scsi", KERNEL=3D"sd*", PROGRAM=3D"/sbin/scsi_id", NAME=3D"%k= ", > > > > SYMLINK=3D"scsi_disks/some-proceeding-stuff-%s{model}-some-followin= g- > > > > stuff" > > > >=20 > > > > Everything after the %s{model} is ignored. > > > >=20 > > > > Furthermore, everything in model following whitespace is ignored as > > > > well. I.e, if model contains "HP 34.7G", the resulting device file > > > > created is /dev/scsi_disks/some-proceeding-stuff-HP. > > > >=20 > > > > I used the following command to run this test: > > > >=20 > > > > # DEVPATH=3D/block/sda ACTION=3Dadd ./udev block > > > >=20 > > > > I also get the same behavior when using udevstart (patched to fix > > > > parameter passing problems). > > >=20 > > > If your sysfs value contains spaces, which is the delimiter for multi= ple > > > symlinks, it will not work. > > >=20 > > > udev can't do this now, you need to wrap the call with an external sc= ript, > > > which ensures sane values. > > >=20 > >=20 > > That explains the spaces. What about stuff trailing %s, if %s does not > > contain spaces. I.e, in the above example, model is ST336753LC and the > > resulting device file is /dev/scsi_disks/some-proceding-stuff- > > ST336753LC. >=20 > I expect the model value has trailing spaces. >=20 > You may look with: > udevinfo -a -p /block/sdX Yes it does, and it seems for most SCSI devices, vendor and model will have trailing spaces. I have included a patch to udev-036 to deal with this issue. It trims off trailing whitespace for all sysfs attributes. It might be better to trim off leading whitespace as well. =20 I also wonder if it might be a good idea to do some sort of transformation for characters in an attribute that are illegal in a file system, rather than just chopping everything off. e.g, spaces that are not leading or trailing would be changed to underscores. Andrew >=20 > Kay >=20 --=20 Andrew Patterson =20 Hewlett-Packard diff -Nur udev-036.orig/namedev.c udev-036/namedev.c --- udev-036.orig/namedev.c 2004-10-12 14:52:18.000000000 -0600 +++ udev-036/namedev.c 2004-10-12 16:51:05.000000000 -0600 @@ -511,7 +511,7 @@ static struct sysfs_attribute *find_sysfs_attribute(struct sysfs_class_dev= ice *class_dev, struct sysfs_device *sysfs_device, char *attr) { struct sysfs_attribute *tmpattr =3D NULL; - char *c; + int endidx; =20 dbg("look for device attribute '%s'", attr); /* try to find the attribute in the class device directory */ @@ -529,9 +529,9 @@ return NULL; =20 attr_found: - c =3D strchr(tmpattr->value, '\n'); - if (c !=3D NULL) - c[0] =3D '\0'; + endidx =3D strcspn(tmpattr->value, " \t\n"); + if (endidx > 0) + tmpattr->value[endidx - 1] =3D '\0'; =20 dbg("found attribute '%s'", tmpattr->path); return tmpattr; --=-3gt5YkB6jAYEYUIIJd+U Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQBBbGL1oKXgdXvblSgRAna6AJ92sO6uNyCvNBNQuh26+dNueZvMTQCg0HXZ Fte0+aQ8GJGVzabBynXVKyc= =OdKn -----END PGP SIGNATURE----- --=-3gt5YkB6jAYEYUIIJd+U-- ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel