linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: compiling problems
Date: Thu, 13 Jan 2005 00:20:57 +0000	[thread overview]
Message-ID: <1105575657.6324.75.camel@localhost.localdomain> (raw)
In-Reply-To: <681F01116A860B46874E634854F4DE620E704C@coastapps.westcoastdhb.org.nz>

On Wed, 2005-01-12 at 13:43 -0800, Greg KH wrote:
> On Wed, Jan 12, 2005 at 09:03:28PM +0100, Kay Sievers wrote:
> > On Wed, 2005-01-12 at 00:09 -0800, Greg KH wrote:
> > > The patch below should fix up the gcc issues.  But you will then get the
> > > following one:
> > >   udev_add.c: In function `rename_net_if':
> > >   udev_add.c:271: structure has no member named `ifr_newname'
> > >   udev_add.c:271: structure has no member named `ifr_newname'
> > >   udev_add.c:271: structure has no member named `ifr_newname'
> > >   udev_add.c:271: structure has no member named `ifr_newname'
> > > 
> > > which is a glibc issue that I don't know how to resolve.  I suggest
> > > building using the klibc that comes with udev and see if that fixes the issue.
> > 
> > Just a very bad hack for your ancient glibc, but seems to work. :)
> > 
> > === udev_add.c 1.87 vs edited ==> > --- 1.87/udev_add.c     2004-12-20 00:57:30 +01:00
> > +++ edited/udev_add.c   2005-01-12 20:59:16 +01:00
> > @@ -268,7 +268,8 @@
> >  
> > 	memset(&ifr, 0x00, sizeof(struct ifreq));
> > 	strfieldcpy(ifr.ifr_name, udev->kernel_name);
> > -	strfieldcpy(ifr.ifr_newname, udev->name);
> > +	//strfieldcpy(ifr.ifr_newname, udev->name);
> > +	strfieldcpy(ifr.ifr_ifru.ifru_data, udev->name);
> >  
> > 	retval = ioctl(sk, SIOCSIFNAME, &ifr);
> > 	if (retval != 0)
> > 
> > 
> 
> Hm, any way to make this work for both libc versions?  Or is this a
> glibc issue that we shouldn't try to work around?

Hmm, I think we should not support that officially by ifdefs and version
magic. The needed bits are added to glibc 2.1.9* in the year 2000.

Or where do you think, we should we draw the line?

Thanks,
Kay



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  parent reply	other threads:[~2005-01-13  0:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-12  7:27 compiling problems Miles Roper
2005-01-12  8:09 ` Greg KH
2005-01-12 20:03 ` Kay Sievers
2005-01-12 21:43 ` Greg KH
2005-01-13  0:20 ` Kay Sievers [this message]
2005-01-13  6:29 ` Miles Roper
2005-01-13  8:53 ` Miles Roper
2005-01-13 16:41 ` Richard Troth
2005-01-13 17:17 ` Greg KH
2005-01-14  7:51 ` Miles Roper
2005-01-19 19:41 ` Greg KH
2005-01-19 21:06 ` Kay Sievers
2005-01-19 21:31 ` Greg KH
2005-01-20  8:12 ` Miles Roper
2005-01-20  8:41 ` Miles Roper
2005-01-20 14:27 ` Greg KH
2005-01-21  9:47 ` Miles Roper
2005-01-21 17:05 ` Greg KH
2005-01-21 18:43 ` Chris Larson
2005-01-25  8:14 ` Miles Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105575657.6324.75.camel@localhost.localdomain \
    --to=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).