From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] Fix GCC4 compile warnings
Date: Sun, 16 Jan 2005 18:31:57 +0000 [thread overview]
Message-ID: <1105900317.4136.15.camel@localhost.localdomain> (raw)
In-Reply-To: <41EAADBC.3050200@access.unizh.ch>
On Sun, 2005-01-16 at 19:09 +0100, Tobias Klauser wrote:
> I tried to compile udev 050plus with the GCC 4.0 snapshot 200412119 and
> got two errors about possibly uninitialized structs, so I fixed this.
> The patch against udev050plus is attached.
Well, these warnings are just wrong! Does this patch avoid the warnings
too? I'm just interested what gcc thinks now. :)
Thanks,
Kay
=== udev_sysfs.c 1.20 vs edited ==--- 1.20/udev_sysfs.c 2004-12-12 00:34:45 +01:00
+++ edited/udev_sysfs.c 2005-01-16 19:24:44 +01:00
@@ -382,9 +382,8 @@
struct sysfs_class_device *wait_class_device_open(const char *path)
{
struct sysfs_class_device *class_dev;
- int loop;
+ int loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND;
- loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND;
while (--loop) {
class_dev = sysfs_open_class_device_path(path);
if (class_dev)
@@ -451,9 +450,8 @@
struct sysfs_device *wait_devices_device_open(const char *path)
{
struct sysfs_device *devices_dev;
- int loop;
+ int loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND;
- loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND;
while (--loop) {
devices_dev = sysfs_open_device_path(path);
if (devices_dev)
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2005-01-16 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 18:09 [PATCH] Fix GCC4 compile warnings Tobias Klauser
2005-01-16 18:31 ` Kay Sievers [this message]
2005-01-16 18:57 ` Kay Sievers
2005-01-16 19:09 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105900317.4136.15.camel@localhost.localdomain \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).