From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Sun, 16 Jan 2005 18:31:57 +0000 Subject: Re: [PATCH] Fix GCC4 compile warnings Message-Id: <1105900317.4136.15.camel@localhost.localdomain> List-Id: References: <41EAADBC.3050200@access.unizh.ch> In-Reply-To: <41EAADBC.3050200@access.unizh.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sun, 2005-01-16 at 19:09 +0100, Tobias Klauser wrote: > I tried to compile udev 050plus with the GCC 4.0 snapshot 200412119 and > got two errors about possibly uninitialized structs, so I fixed this. > The patch against udev050plus is attached. Well, these warnings are just wrong! Does this patch avoid the warnings too? I'm just interested what gcc thinks now. :) Thanks, Kay === udev_sysfs.c 1.20 vs edited ==--- 1.20/udev_sysfs.c 2004-12-12 00:34:45 +01:00 +++ edited/udev_sysfs.c 2005-01-16 19:24:44 +01:00 @@ -382,9 +382,8 @@ struct sysfs_class_device *wait_class_device_open(const char *path) { struct sysfs_class_device *class_dev; - int loop; + int loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND; - loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND; while (--loop) { class_dev = sysfs_open_class_device_path(path); if (class_dev) @@ -451,9 +450,8 @@ struct sysfs_device *wait_devices_device_open(const char *path) { struct sysfs_device *devices_dev; - int loop; + int loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND; - loop = WAIT_MAX_SECONDS * WAIT_LOOP_PER_SECOND; while (--loop) { devices_dev = sysfs_open_device_path(path); if (devices_dev) ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel