[PATCH, UDEV] use an unsigned int for kernel release number

[PATCH, UDEV] use an unsigned int for kernel release number

[Michael Buesch]

[-- Attachment #1.1: Type: text/plain, Size: 296 bytes --]

Hi,

This fixes kernel_release_satisfactory().
We are already using %u in the sscanf() format string.
The patch replaces the int for the kernel release number with
unsigned int, as we can never have negative release numbers.

-- 
Regards Michael Buesch  [ http://www.tuxsoft.de.vu ]



[-- Attachment #1.2: udev_unsigned_int_for_kernrelease.diff --]
[-- Type: text/x-diff, Size: 1289 bytes --]

===== udev_utils.c 1.25 vs edited =====
--- 1.25/udev_utils.c	2004-12-20 22:10:57 +01:00
+++ edited/udev_utils.c	2005-02-05 17:21:40 +01:00
@@ -62,11 +62,11 @@
 	strcpy(udev->group, "root");
 }
 
-int kernel_release_satisfactory(int version, int patchlevel, int sublevel)
+int kernel_release_satisfactory(unsigned int version, unsigned int patchlevel, unsigned int sublevel)
 {
-	static int kversion = 0;
-	static int kpatchlevel;
-	static int ksublevel;
+	static unsigned int kversion = 0;
+	static unsigned int kpatchlevel;
+	static unsigned int ksublevel;
 
 	if (kversion == 0) {
 		struct utsname uts;
===== udev_utils.h 1.20 vs edited =====
--- 1.20/udev_utils.h	2004-12-19 23:38:32 +01:00
+++ edited/udev_utils.h	2005-02-05 17:21:16 +01:00
@@ -77,7 +77,7 @@
 #endif
 
 extern void udev_init_device(struct udevice *udev, const char* devpath, const char *subsystem);
-extern int kernel_release_satisfactory(int version, int patchlevel, int sublevel);
+extern int kernel_release_satisfactory(unsigned int version, unsigned int patchlevel, unsigned int sublevel);
 extern int create_path(const char *path);
 extern int parse_get_pair(char **orig_string, char **left, char **right);
 extern int file_map(const char *filename, char **buf, size_t *bufsize);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH, UDEV] use an unsigned int for kernel release number

[Kay Sievers]

On Sat, 2005-02-05 at 17:26 +0100, Michael Buesch wrote:
> This fixes kernel_release_satisfactory().
> We are already using %u in the sscanf() format string.
> The patch replaces the int for the kernel release number with
> unsigned int, as we can never have negative release numbers.

Applied.

Thanks,
Kay



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel