From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Tue, 08 Feb 2005 20:38:46 +0000 Subject: Re: patches from the debian package Message-Id: <1107895126.5536.50.camel@localhost.localdomain> List-Id: References: <20050205155031.GA12611@wonderland.linux.it> In-Reply-To: <20050205155031.GA12611@wonderland.linux.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, 2005-02-08 at 12:11 -0800, Patrick Mansfield wrote: > On Tue, Feb 08, 2005 at 08:50:10PM +0100, Kay Sievers wrote: > > On Mon, 2005-02-07 at 10:39 -0800, Patrick Mansfield wrote: > > > So it also needs code changes to use the DEVPATH plus any command line > > > option, and/or a new % value for the sysfs path, like: > > > > > > PROGRAM="scsi_id -d %N -s %p", ... > > > > Ok, I did that. We will have %N and %p now. > > > > It should still figure out whether or not to print a trailing "\n" for > > > normal command line usage. DEVPATH set could be the trigger, though that > > > is not clean (using -s for sysfs path, but then using DEVPATH to > > > figure out if \n is printed). > > > > RESULT does not care about a trailing \n. > > Okay. Then there is no change needed in scsi_id, and that code should be > removed from it. I'm not sure if scsi_id DEVPATH environment variable > usage should be removed (for backwards compatibility). I think that functionality it's not really needed outside of udev. But you still use it for vpd@page0 validation. You may compare that with inquiry@page0 instead of using the vendor/model values from sysfs? > Given this change, can you revert the tmp directory change (if Marco's OK > with that)? Mainly for non-udev command line usage. I will do that. Care to give it a try, if it really works with the new code. Also with the \n RESULT matching. Thanks, Kay ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel