From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Tue, 08 Feb 2005 21:59:58 +0000 Subject: Re: patches from the debian package Message-Id: <1107899998.5536.62.camel@localhost.localdomain> List-Id: References: <20050205155031.GA12611@wonderland.linux.it> In-Reply-To: <20050205155031.GA12611@wonderland.linux.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, 2005-02-08 at 13:32 -0800, Patrick Mansfield wrote: > On Tue, Feb 08, 2005 at 09:38:46PM +0100, Kay Sievers wrote: > > On Tue, 2005-02-08 at 12:11 -0800, Patrick Mansfield wrote: > > > > Okay. Then there is no change needed in scsi_id, and that code should be > > > removed from it. I'm not sure if scsi_id DEVPATH environment variable > > > usage should be removed (for backwards compatibility). > > > > I think that functionality it's not really needed outside of udev. > > But you still use it for vpd@page0 validation. You may compare that with > > inquiry@page0 instead of using the vendor/model values from sysfs? > > I'm not sure what you mean by the above. Can you clarify? Or does the > following answer your question? > > The DEVPATH usage and hotplug_mode are mainly for use with udev, the code > is also there for ease of use in any hotplug program (though a script > can easily run scsi_id -s ${DEVPATH}). > > There are also some other oddities based on hotplug_mode being set (use > syslog, don't warn on what would be errors for command line usage). > > I get the vendor/model via sysfs as there are some quirks related to use > of the INQUIRY and I did not want to duplicate that code or the devinfo > list (black/white list, see drivers/scsi/scsi_scan.c and the scsi_devinfo.c > table; especially the BLIST_INQUIRY_36 and 58). I was just asking if a compare between the results of page0 vpd=0 and vpd=1 would be sufficient to make sure that the right page0 is returned. And we wouldn't need the devpath at all. I see the reason now. Well, I like broken hardware. :) Thanks, Kay ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel