From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Mon, 28 Feb 2005 20:37:29 +0000 Subject: Re: The Next Generation Message-Id: <1109623049.4228.18.camel@localhost.localdomain> List-Id: References: <20050217190941.GA1561@vrfy.org> In-Reply-To: <20050217190941.GA1561@vrfy.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Mon, 2005-02-28 at 22:11 +0300, Roman Kagan wrote: >On Mon, Feb 28, 2005 at 07:41:41PM +0100, Kay Sievers wrote: >> I've changes the HOTPLUG key to be able to read a whole subdirectory >> with a wildcard instead of only one file. The following three rules will >> emulate the dev.d/ directory handling we currently have compiled in: >> >> HOTPLUG="/etc/dev.d/%D/*.dev" >> HOTPLUG="/etc/dev.d/%S/*.dev" >> HOTPLUG="/etc/dev.d/default/*.dev" > >Given that this is a compatibility stuff, can't it be handled >externally, without bloating udev? E.g. > >HOTPLUG="/usr/bin/run-parts /etc/dev.d/default" >or even simply > >HOTPLUG="sh -c 'for f in /etc/dev.d/default/*.dev; do [ -x \$f ] && \$f; done'" Sure, something like that should work too. It was easy to do this inside of udev, don't know what's better here. The internal one can sort out doubles, from all all the keys, but that isn't a required feature... >Another suggestion is of a syntactic sugar kind: would it be too hard to >implement key substitution in actions with a generic syntax, rather than >adding %-conversion specifier for each possible substitution, e.g. > >HOTPLUG="foo $SUBSYSTEM $SYSFS{bar} $ENV{baz}" No, that is not really hard. I thought about something like this too, if we are running out of nice characters. :) It is nicer to read, yes. But renaming some of the keys would be nice too, like: ADD_SYMLINK, ADD_HOTPLUG, MATCH_ACTION, SET_GROUP, SET_MODE, SET_NAME so the key can tell you what it does in reality. Today you need to know that KERNEL= is a match instruction, SYMLINK= will add something to a list and GROUP= will override any value. Sometimes, we should do all that. :) Thanks, Kay ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel