From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH 4/4] Fix -Wall warnings in udev 054 (volume_id)
Date: Thu, 10 Mar 2005 17:52:47 +0000 [thread overview]
Message-ID: <1110477167.5137.86.camel@localhost.localdomain> (raw)
In-Reply-To: <20050310144334.GA4453@localhost.localdomain>
On Thu, 2005-03-10 at 15:43 +0100, Tobias Klauser wrote:
> Hi,
>
> The following patch fixes some warnings when compiling volume_id
> from udev with the -Wall compiler flag. Define _GNU_SOURCE for
> strnlen() and correct the path to logging.h
>
> Thanks, Tobias
>
> Signed-off-by: Tobias Klauser <tklauser@access.unizh.ch>
>
> diff -urpN udev-054.orig/extras/volume_id/udev_volume_id.c udev-054/extras/volume_id/udev_volume_id.c
> --- udev-054.orig/extras/volume_id/udev_volume_id.c 2005-03-01 21:19:49.000000000 +0100
> +++ udev-054/extras/volume_id/udev_volume_id.c 2005-03-04 00:44:14.000000000 +0100
> @@ -21,6 +21,8 @@
> *
> */
>
> +#define _GNU_SOURCE
> +
> #include <stdio.h>
> #include <stdlib.h>
> #include <unistd.h>
> diff -urpN udev-054.orig/extras/volume_id/volume_id/logging.h udev-054/extras/volume_id/volume_id/logging.h
> --- udev-054.orig/extras/volume_id/volume_id/logging.h 2005-03-01 21:19:49.000000000 +0100
> +++ udev-054/extras/volume_id/volume_id/logging.h 2005-03-04 00:17:06.000000000 +0100
> @@ -16,6 +16,6 @@
> #endif
>
> /* just use the udev version */
> -#include "../../logging.h"
> +#include "../../../logging.h"
Applied.
Thanks,
Kay
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2005-03-10 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 14:43 [PATCH 4/4] Fix -Wall warnings in udev 054 (volume_id) Tobias Klauser
2005-03-10 17:52 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110477167.5137.86.camel@localhost.localdomain \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).