From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Thu, 10 Mar 2005 17:52:59 +0000 Subject: Re: [PATCH 3/4] Fix -Wall warnings in udev 054 (chassis_id) Message-Id: <1110477180.5137.88.camel@localhost.localdomain> List-Id: References: <20050310144021.GA4405@localhost.localdomain> In-Reply-To: <20050310144021.GA4405@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Thu, 2005-03-10 at 15:40 +0100, Tobias Klauser wrote: > Hi, > > The following patch fixes a warning when compiling chassis_id > from udev with the -Wall compiler flag. There are too much > conversions in the format string of sscanf(). One %d can be > dropped. > > Thanks, Tobias > > Signed-off-by: Tobias Klauser > > diff -urpN udev-054.orig/extras/chassis_id/table.c udev-054/extras/chassis_id/table.c > --- udev-054.orig/extras/chassis_id/table.c 2005-03-01 21:19:49.000000000 +0100 > +++ udev-054/extras/chassis_id/table.c 2005-03-06 15:41:49.000000000 +0100 > @@ -59,7 +59,7 @@ int table_init(void) > i = 0; > while (!feof(fp)) { > fgets(ptr, 80, fp); > - sscanf(ptr, "%d %d %d %d %d %s %s", &ptable[i].id, > + sscanf(ptr, "%d %d %d %d %s %s", &ptable[i].id, > &ptable[i].num_disks, > &ptable[i].chassis_num, &ptable[i].slot_num, > ptable[i].serial_num, ptable[i].name); Applied. Thanks, Kay ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel