From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Tue, 15 Mar 2005 15:49:00 +0000 Subject: Re: Fix udev_volume_id for reiserfs v3.5 Message-Id: <1110901740.6630.83.camel@localhost.localdomain> List-Id: References: <4236E0AA.8000605@suse.de> In-Reply-To: <4236E0AA.8000605@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, 2005-03-15 at 16:17 +0100, Hannes Reinecke wrote: > Kay Sievers wrote: > > On Tue, 2005-03-15 at 14:18 +0100, Hannes Reinecke wrote: > >>the attached patch fixes udev_volume_id for old reiserfs volumes. > > > > The signature for that version can be at the offset of the later > > versions? We already check for that signature at a different offset. > > > Appearently so. > > >>How are we supposed to handle old/invalid labels? > >>The one I'm reading here is > >>eb 4d 72 17 06 4e 72 17 09 4e 72 17 53 4e 72 17 > >>which is clearly bogus. I'll check with our fs-gurus but I think > >>we should filter them out in udev_volume_id. > >>Can't we test for isascii(rs->label[0]) ? > > > > If that helps, sure. But what if the garbage starts at the second char? > > And what's with the UTF8 char sequences? > > > Well, I just asked our resident reiserfs guru (thx mason :-). > Reiser v3.5 does not support labels nor uuids. > Corrected patch attached. Nice! Applied, thanks. Kay ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel