[PATCH] fix firmware.agent for multiple sysfs mounts

[PATCH] fix firmware.agent for multiple sysfs mounts

[Bill Nottingham]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Not sure when you'd normally end up with this, but someone
reported it in our bugzilla. Fixes firmware.agent breaking
completely if sysfs is mounted on multiple paths.

Bill

[-- Attachment #2: hotplug-2004_09_23-firmwaresys.patch --]
[-- Type: text/plain, Size: 436 bytes --]

--- hotplug-2004_09_23/etc/hotplug/firmware.agent.foo	2005-04-27 12:37:21.000000000 -0400
+++ hotplug-2004_09_23/etc/hotplug/firmware.agent	2005-04-27 12:37:46.000000000 -0400
@@ -23,7 +23,7 @@
 FIRMWARE_DIR=/lib/firmware
 
 # mountpoint of sysfs
-SYSFS=$(sed -n 's/^.* \([^ ]*\) sysfs .*$/\1/p' /proc/mounts)
+SYSFS=$(awk '$3 == "sysfs" { print $2 ; nextfile }' /proc/mounts)
 
 # use /proc for 2.4 kernels
 if [ "$SYSFS" = "" ]; then

Re: [PATCH] fix firmware.agent for multiple sysfs mounts

[Marcel Holtmann]

Hi Bill,

> Not sure when you'd normally end up with this, but someone
> reported it in our bugzilla. Fixes firmware.agent breaking
> completely if sysfs is mounted on multiple paths.

I am fine with that patch, but who is mounting sysfs multiple times?

Regards

Marcel




-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start!  http://www.idcswdc.com/cgi-bin/survey?id\x105hix
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] fix firmware.agent for multiple sysfs mounts

[Bill Nottingham]

Marcel Holtmann (marcel@holtmann.org) said: 
> > Not sure when you'd normally end up with this, but someone
> > reported it in our bugzilla. Fixes firmware.agent breaking
> > completely if sysfs is mounted on multiple paths.
> 
> I am fine with that patch, but who is mounting sysfs multiple times?

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id\x143066

Apparently showed up for someone with XFS somehow, although I'm
not sure how that would be related. Basically, the sysfs from
the initrd/initramfs couldn't get unmounted due to -EBUSY, and so you
eventually ended up with 2.

Bill


-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start!  http://www.idcswdc.com/cgi-bin/survey?id\x105hix
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] fix firmware.agent for multiple sysfs mounts

[Marco d'Itri]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

On Apr 28, Marcel Holtmann <marcel@holtmann.org> wrote:

> I am fine with that patch, but who is mounting sysfs multiple times?
People with a chroot environment, for a start.

-- 
ciao,
Marco

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fix firmware.agent for multiple sysfs mounts

[Linas Vepstas]

On Thu, Apr 28, 2005 at 06:50:41PM +0200, Marco d'Itri was heard to remark:
> On Apr 28, Marcel Holtmann <marcel@holtmann.org> wrote:
> 
> > I am fine with that patch, but who is mounting sysfs multiple times?
> People with a chroot environment, for a start.

linux-vserver too, I guess ??


--linas


-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start!  http://www.idcswdc.com/cgi-bin/survey?id\x105hix
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel