linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Scott James Remnant <scott@ubuntu.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org,
	linux-hotplug-devel@lists.sourceforge.net,
	Ben Collins <ben.collins@ubuntu.com>
Subject: Re: Problem with IDE driver not claiming the disk
Date: Tue, 06 Dec 2005 12:39:30 +0000	[thread overview]
Message-ID: <1133872770.8181.99.camel@localhost.localdomain> (raw)
In-Reply-To: <58cb370e0512060023w3ce35e9bk316ff6eb3f7e43f9@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

On Tue, 2005-12-06 at 09:23 +0100, Bartlomiej Zolnierkiewicz wrote:

> On 12/6/05, Scott James Remnant <scott@ubuntu.com> wrote:
> > I was first hoping it was a glaringly obvious thing we were doing wrong,
> > and wouldn't come to comparing kernel code;  the kernel is the current
> > Ubuntu one, it's based off 2.6.15 -- our patches are all in git:
> >
> > http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-2.6.git
> >
> > I'm not best placed to answer the patches that are in the exact version
> > I used ("our" 2.6.15-6.8), Ben Collins is (Cc'd).
> 
> You have IDE patches in your tree, please try vanilla 2.6.15.
> 
Yeah, one was compiling over night (still waiting for my AMD64 beast to
arrive) and I tried it out this morning ... I see your point, it works
exactly as advertised in vanilla 2.6.15-rc5 -- loading the real IDE
driver finds the devices itself, and there's no need to load
ide-generic.

> Changes to setup-pci.c and ide-generic.c in the following patch are wrong:
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-2.6.git;a=commitdiff;h=149744c1475cdaf2c6babfd92f163cca8f10c540;hp=5a373d68631531fff09047364be4565d67335f08
> 
> It seems that with this patch 'pre_init' in setup-pci.c. will
> become '0' (it equals '1' initially) only after ide-generic is loaded...
> and ide_pci_register_driver() checks 'pre_init' value.
> 
> Sigh, this patch was NACK-ed upstream for some (important) reasons...
> 
I'll go bludgeon our kernel guy for a bit then!

Thanks for your time,

Scott
-- 
Scott James Remnant
scott@ubuntu.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2005-12-06 12:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-05 23:56 Problem with IDE driver not claiming the disk Scott James Remnant
2005-12-06  0:34 ` Bartlomiej Zolnierkiewicz
2005-12-06  1:36   ` Scott James Remnant
2005-12-06  8:23     ` Bartlomiej Zolnierkiewicz
2005-12-06 12:39       ` Scott James Remnant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133872770.8181.99.camel@localhost.localdomain \
    --to=scott@ubuntu.com \
    --cc=ben.collins@ubuntu.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).