Re: path_id / sun x4200 / mtp_sas

[Kay Sievers <kay.sievers@vrfy.org>]

On Fri, 2006-05-26 at 15:21 +0200, Sten Spans wrote:
> On Fri, 26 May 2006, Kay Sievers wrote:
> 
> > On Tue, 2006-05-23 at 17:01 +0200, Sten Spans wrote:
> >> The new sas support added between 0.085 and 0.092
> >> causes quite severe problems on sun x4200 servers with
> >> mptsas sas controller. I'm seeing these problems
> >> on debian testing / 0.092, with a query for "/block/sdb".
> >>
> >> The handle_sas routine fails to return something useful
> >> which leads to an infinite loop in the while loop starting
> >> at line 379.
> >>
> >> handle_sas gets called with
> >> "/sys/devices/pci0000:00/0000:00:02.0/0000:02:03.0/host0/phy-0:1/rphy-0:1/target0:1:1/0:1:1:0"
> >>
> >> which results in:
> >> sas_host_path=/sys/devices/pci0000:00/0000:00:02.0/0000:02:03.0/host0
> >> sas_phy_path=phy-0:1/rphy-0:1
> >> sas_phy_id=phy-0:1
> >> sas_rphy_id=rphy-0:1
> >> sas_phy_dev=/sys/class/sas_phy/phy-0:1
> >> phy_address=0x50003ba0000003bb
> >> sas_rphy_dev=/sys/class/sas_device/rphy-0:1
> >>
> >> however the test at line 298 fails so $rphy_address remains
> >> empty, and the while loop at line 379 restarts with the same input.
> >>
> >> It looks like sas_rphy_dev shouldn't be
> >> /sys/class/sas_device/rphy-0:1 but /sys/class/sas_rphy/rphy-0\:1.
> >>
> >> Which leads to the following patch:
> >> --- path_id     2006-05-24 01:54:45.000000000 +0200
> >> +++ path_id.sten        2006-05-24 01:54:21.000000000 +0200
> >> @@ -294,7 +294,7 @@
> >>                  return
> >>          fi
> >>          sas_phy_address="$phy_address:$phy_port:$phy_id"
> >> -       sas_rphy_dev="/sys/class/sas_device/${sas_rphy_id}"
> >> +       sas_rphy_dev="/sys/class/sas_rphy/${sas_rphy_id}"
> >
> > This is expected to be already fixed in udev 091:
> >  http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=commitdiff;h±2a1fb1c6073c0679e80f515fe97cb21fa88e65
> 
> I looked at 092 and it was broken there....

Ah ok. See this:
  http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h/8600dff2b140096a7df781884e918a16aa90e0

"sas_rphy" does not exist anymore.

Thanks,
Kay



-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x107521&bid$8729&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel