From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Fri, 25 May 2007 02:04:38 +0000 Subject: Re: support for vfat long filenames Message-Id: <1180058678.16339.4.camel@lov.localdomain> List-Id: References: <1179900959.20773.3.camel@moonpix.desrt.ca> In-Reply-To: <1179900959.20773.3.camel@moonpix.desrt.ca> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, 2007-05-23 at 10:18 -0400, Ryan Lortie wrote: > On Wed, 2007-23-05 at 08:42 +0200, Kay Sievers wrote: > > On 5/23/07, Ryan Lortie wrote: > > > here's a first go at a patch to implement long filename support for vfat > > > in libvolume_id. > > > > > > i'm not on the list, so please keep me cc:'d in on any discussion... > > > > Oh, does that mean that fat can have labels with long filenames? What > > tool can create these long labels, can you set such labels with > > Windows now? > i've been using the mtools package (specifically, "mlabel") to test my > work. it supports long labels in exactly the way you would expect. Ah nice. Unfortunately, seems it doesn't handle UTF8 correctly. It encodes all multibyte chars to individual 16bit values and writes these to the disk. > desrt@moonpix:~$ sudo mdir -i /dev/sdc2 :: > Volume in drive : is My iPod has a very long name! (abbr=MY IPOD HAS) > > i don't know about windows since i don't have access to a windows box, > but i assume it's true there too....? I tried it, both Windows XP and MacOS can't read or set the long labels. :) > > Can you use volume_id_set_unicode16() in utils.c, or is that different? > ah. i didn't know about this. done :) > > > > And please don't use assert(), just return no label if something goes wrong. > done -- this part is reworked a little to use memcpy anyway. > > also fixed some small indentation and { placement issues. I've committed it with a few small changes. We better don't use statically allocated strings, it may cause problems in threaded apps. Please check, if it still works for you. :) Thanks, Kay ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel