Linux Hotplug development
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] build-sys: remove non-POSIX variable names
Date: Tue, 12 Aug 2008 22:01:46 +0000	[thread overview]
Message-ID: <1218578507-28586-3-git-send-email-kzak@redhat.com> (raw)

Makefile.am:24: shell echo $$(( $(VERSION: non-POSIX variable name
Makefile.am:24: (probably a GNU make extension)
Makefile.am:26: shell echo $$(($(VERSION: non-POSIX variable name
Makefile.am:26: (probably a GNU make extension)
Makefile.am:29: shell echo $$(($(VERSION: non-POSIX variable name
Makefile.am:29: (probably a GNU make extension)

Signed-off-by: Karel Zak <kzak@redhat.com>
---
 Makefile.am |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index ae21bca..a4260ea 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -12,6 +12,8 @@ EXTRA_DIST = \
 	docs \
 	autogen.sh
 
+PREVIOUS_VERSION = `expr $(VERSION) - 1`
+
 distclean-local:
 	rm -f *~
 	rm -rf autom4te.cache
@@ -21,12 +23,12 @@ distclean-local:
 	rm -f udev-$(VERSION).tar.gz udev-$(VERSION).tar.bz2
 
 changelog:
-	@ head -1 ChangeLog | grep -q "to v$(shell echo $$(($(VERSION) - 1)))"
+	@ head -1 ChangeLog | grep -q "to $(PREVIOUS_VERSION)"
 	@ mv ChangeLog ChangeLog.tmp
-	@ echo "Summary of changes from v$(shell echo $$(($(VERSION) - 1))) to v$(VERSION)" >> ChangeLog
+	@ echo "Summary of changes from v$(PREVIOUS_VERSION) to v$(VERSION)" >> ChangeLog
 	@ echo "======================" >> ChangeLog
 	@ echo >> ChangeLog
-	@ git log --pretty=short $(shell echo $$(($(VERSION) - 1)))..HEAD | git shortlog  >> ChangeLog
+	@ git log --pretty=short $(PREVIOUS_VERSION)..HEAD | git shortlog  >> ChangeLog
 	@ echo >> ChangeLog
 	@ cat ChangeLog
 	@ cat ChangeLog.tmp >> ChangeLog
-- 
1.5.5.1


             reply	other threads:[~2008-08-12 22:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-12 22:01 Karel Zak [this message]
2008-08-13 10:03 ` [PATCH] build-sys: remove non-POSIX variable names Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218578507-28586-3-git-send-email-kzak@redhat.com \
    --to=kzak@redhat.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox