[PATCH] usb_id: fix warning (undefined _GNU_SOURCE)

[PATCH] usb_id: fix warning (undefined _GNU_SOURCE)

[Karel Zak]

  usb_id.c: In function ‘set_str’:
  usb_id.c:69  warning: implicit declaration of function ‘strnlen’

IMHO this patch is workaround. The correct way is to use "-include
$(top_builddir)/config.h" as a gcc option. I'll submit a patch with
this solution later.

Signed-off-by: Karel Zak <kzak@redhat.com>
---
 extras/usb_id/usb_id.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/extras/usb_id/usb_id.c b/extras/usb_id/usb_id.c
index 5b78b97..53a952b 100644
--- a/extras/usb_id/usb_id.c
+++ b/extras/usb_id/usb_id.c
@@ -11,6 +11,8 @@
  *	Free Software Foundation version 2 of the License.
  */
 
+#include "../../config.h"
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>
-- 
1.5.5.1

Re: [PATCH] usb_id: fix warning (undefined _GNU_SOURCE)

[Kay Sievers]

On Wed, 2008-08-13 at 00:01 +0200, Karel Zak wrote:
> usb_id.c: In function ‘set_str’:
>   usb_id.c:69  warning: implicit declaration of function ‘strnlen’

I did add the include already locally.

> IMHO this patch is workaround. The correct way is to use "-include
> $(top_builddir)/config.h" as a gcc option. I'll submit a patch with
> this solution later.

Yeah, makes sense, so we can remove all the includes and ifdefs in a
whole bunch of files.

Thanks,
Kay