From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Wed, 13 Aug 2008 10:05:31 +0000 Subject: Re: [PATCH] usb_id: fix warning (undefined _GNU_SOURCE) Message-Id: <1218621931.2426.19.camel@lgn.site> List-Id: References: <1218578507-28586-4-git-send-email-kzak@redhat.com> In-Reply-To: <1218578507-28586-4-git-send-email-kzak@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-hotplug@vger.kernel.org On Wed, 2008-08-13 at 00:01 +0200, Karel Zak wrote: > usb_id.c: In function ‘set_str’: > usb_id.c:69 warning: implicit declaration of function ‘strnlen’ I did add the include already locally. > IMHO this patch is workaround. The correct way is to use "-include > $(top_builddir)/config.h" as a gcc option. I'll submit a patch with > this solution later. Yeah, makes sense, so we can remove all the includes and ifdefs in a whole bunch of files. Thanks, Kay