From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
David Miller <davem@davemloft.net>,
Marcel Holtmann <marcel@holtmann.org>,
linux-hotplug@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netdev: generate kobject uevent on network events.
Date: Mon, 24 Nov 2008 20:06:14 +0000 [thread overview]
Message-ID: <1227557174.3162.7.camel@achroite> (raw)
In-Reply-To: <20081124114522.1e8de3fe@extreme>
On Mon, 2008-11-24 at 11:45 -0800, Stephen Hemminger wrote:
[...]
> + case NETDEV_CHANGE:
> + if (netif_running(netdev)) {
> + char str[64] = "DEVSTATE=UP";
> + char *envp[2] = { str, NULL };
> +
> + if (netif_oper_up(netdev))
> + strcat(str, ",RUNNING");
> + if (netif_carrier_ok(netdev))
> + strcat(str, ",LOWER_UP");
> + if (netif_dormant(netdev))
> + strcat(str, ",DORMANT");
> + kobject_uevent_env(&netdev->dev.kobj, KOBJ_CHANGE, envp);
> + }
> + break;
Unless I'm much mistaken, NETDEV_CHANGE should only be generated when
netif_running() is true, so the test is redundant.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2008-11-24 20:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 7:41 [RFC] network devices generating uevents? Stephen Hemminger
2008-11-22 14:08 ` Kay Sievers
2008-11-22 19:22 ` Karl O. Pinc
2008-11-23 2:13 ` Marcel Holtmann
2008-11-23 6:32 ` Stephen Hemminger
2008-11-23 16:13 ` Kay Sievers
2008-11-24 19:45 ` [PATCH] netdev: generate kobject uevent on network events Stephen Hemminger
2008-11-24 19:55 ` Kay Sievers
2008-11-24 20:06 ` Stephen Hemminger
2008-11-25 8:39 ` David Miller
2008-11-24 20:06 ` Ben Hutchings [this message]
2008-11-24 23:03 ` [PATCH] netdev: generate kobject uevent on network state Stephen Hemminger
2008-11-25 3:08 ` [PATCH] netdev: generate kobject uevent on network state transitions Kay Sievers
2008-11-25 3:51 ` Marcel Holtmann
2008-11-25 4:14 ` [PATCH] netdev: generate kobject uevent on network state Stephen Hemminger
2008-11-25 9:09 ` David Miller
2008-11-26 5:24 ` [PATCH] netdev: generate kobject uevent on network state transitions Marcel Holtmann
2008-11-26 12:09 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227557174.3162.7.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).