linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: Add user ACLs for /dev/rfkill
Date: Fri, 31 Jul 2009 11:47:45 +0000	[thread overview]
Message-ID: <1249040865.23662.14.camel@localhost.localdomain> (raw)
In-Reply-To: <4A72CE4E.3030205@redhat.com>

Hi Harald,

> From 6e4ceb8205a7027b750d0cf1477834e91341e502 Mon Sep 17 00:00:00 2001
> From: Harald Hoyer <harald@redhat.com>
> Date: Fri, 31 Jul 2009 12:55:49 +0200
> Subject: [PATCH] 70-acl.rules: add rfkill switch

do you mind using git send-email instead of just attaching the patch
without any email body.

> For gnome-bluetooth's killswitch code to work, the user on the local
> console needs to have access to /dev/rfkill.
> 
> see https://bugzilla.redhat.com/show_bug.cgi?idQ4798
> ---
>  extras/udev-acl/70-acl.rules |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/extras/udev-acl/70-acl.rules
> b/extras/udev-acl/70-acl.rules
> index f41bb66..85ea8a1 100644
> --- a/extras/udev-acl/70-acl.rules
> +++ b/extras/udev-acl/70-acl.rules
> @@ -44,6 +44,9 @@ SUBSYSTEM="misc", KERNEL="kvm",
> ENV{ACL_MANAGE}="1"
>  # smart-card readers
>  ENV{ID_SMARTCARD_READER}="*?", ENV{ACL_MANAGE}="1"
>  
> +# rfkill switch
> +KERNEL="rfkill", ENV{ACL_MANAGE}="1"
> +

I am not convinced this is the right way to do. Exposing the RFKILL
control to the console user might be wrong.

Regards

Marcel



  reply	other threads:[~2009-07-31 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 10:58 Add user ACLs for /dev/rfkill Harald Hoyer
2009-07-31 11:47 ` Marcel Holtmann [this message]
2009-08-07 12:27 ` Harald Hoyer
2009-08-07 12:38 ` Kay Sievers
2009-08-07 14:22 ` Bill Nottingham
2009-08-07 17:30 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249040865.23662.14.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).