Linux Hotplug development
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: linux-hotplug@vger.kernel.org
Subject: [BUG] udev doesn't run blkid on cdroms with one session
Date: Sun, 20 Sep 2009 01:49:12 +0000	[thread overview]
Message-ID: <1253411352.3791.14.camel@maxim-laptop> (raw)

A line in 60-persistent-storage.rules states:

KERNEL="sr*", ENV{ID_CDROM_MEDIA}="?*", IMPORT{program}="/sbin/blkid -o udev -p -u noraid -O $env{ID_CDROM_MEDIA_SESSION_LAST_OFFSET} $tempnode"

It seems to assume that ID_CDROM_MEDIA_SESSION_LAST_OFFSET is always
set, since otherwise blkid fails:

maxim@maxim-laptop:~$ /sbin/blkid -o udev -p -u noraid -O  /dev/sr0
The low-probe option requires a device
maxim@maxim-laptop:~$ /sbin/blkid -o udev -p -u noraid   /dev/sr0
ID_FS_LABELÍROM
ID_FS_LABEL_ENCÍROM\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
ID_FS_VERSION=Joliet\x20Extension
ID_FS_TYPE=iso9660
ID_FS_USAGE=filesystem
maxim@maxim-laptop:~$ /sbin/blkid -o udev -p -u noraid -O 0  /dev/sr0
ID_FS_LABELÍROM
ID_FS_LABEL_ENCÍROM\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
ID_FS_VERSION=Joliet\x20Extension
ID_FS_TYPE=iso9660
ID_FS_USAGE=filesystem
maxim@maxim-laptop:~$ 


Maybe this is a change in blkid
(btw, you notice obvious bug, the label is 'padded' with spaces, I will
report that to util-linux package maintainers)


Now, ether the rule has to be split in two, or cdrom_id changed.

Currently in cdrom_id:

	if (cd_media_session_last_offset > 0)
		printf("ID_CDROM_MEDIA_SESSION_LAST_OFFSET=%llu\n", cd_media_session_last_offset);



Now, it is impossible to use any disks, since without blkid environment,
devicekit doesn't recognize the cdrom at all.


Best regards,
Maxim Levitsky


             reply	other threads:[~2009-09-20  1:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-20  1:49 Maxim Levitsky [this message]
2009-09-20  4:00 ` [BUG] udev doesn't run blkid on cdroms with one session Kay Sievers
2009-09-20 21:28 ` Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253411352.3791.14.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox