linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] modem-modeswitch: 61-option-modem-modeswitch.rules only
Date: Sun, 22 Nov 2009 22:38:21 +0000	[thread overview]
Message-ID: <1258929501.12095.13.camel@localhost.localdomain> (raw)

Make people aware that they shouldn't add devices not manufactured by
Option NV to 61-option-modem-modeswitch.rules.  modem-modeswitch only
supports ejecting the fake CD for Option NV devices at this time.
People should be using (and fixing) usb_modeswitch instead of
modem-modeswitch.

Signed-off-by: Dan Williams <dcbw@redhat.com>

---
Note: this patch depends on the revert of
53842b53820a0f0b2b0ff5b28caf01e3f7e26f22 and
5052297b6a8928d3ccfdd9996b71fdfff8bc8921.

Note #2; please CC-me in all replies as I'm not subscribed to the list.

diff --git a/extras/modem-modeswitch/61-option-modem-modeswitch.rules b/extras/modem-modeswitch/61-option-modem-modeswitch.rules
index 3ef6f08..933368c 100644
--- a/extras/modem-modeswitch/61-option-modem-modeswitch.rules
+++ b/extras/modem-modeswitch/61-option-modem-modeswitch.rules
@@ -1,3 +1,6 @@
+# NOTE: only for devices manufactured by Option NV
+# DO NOT add devices that are not manufactured by Option NV
+
 ACTION!="add", GOTO="option_zerocd_end"
 
 SUBSYSTEM="usb", ATTR{bDeviceClass}!="ff", ENV{DEVTYPE}="usb_device", GOTO="option_zerocd_disable"
@@ -34,5 +37,8 @@ ATTRS{idVendor}="0af0", ATTRS{idProduct}="7401", RUN+="modem-modeswitch -v 0x%
 ATTRS{idVendor}="0af0", ATTRS{idProduct}="7501", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t option-zerocd"
 ATTRS{idVendor}="0af0", ATTRS{idProduct}="7601", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t option-zerocd"
 ATTRS{idVendor}="0af0", ATTRS{idProduct}="7901", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t option-zerocd"
+
+# NOTE: only for devices manufactured by Option NV
+# DO NOT add devices that are not manufactured by Option NV
 
 LABEL="option_zerocd_end"





             reply	other threads:[~2009-11-22 22:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-22 22:38 Dan Williams [this message]
2009-11-23 20:49 ` [PATCH] modem-modeswitch: 61-option-modem-modeswitch.rules only Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258929501.12095.13.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).