From: Michael Ellerman <michael@ellerman.id.au>
To: "K, Narendra" <Narendra_K@dell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-hotplug@vger.kernel.org" <linux-hotplug@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Domsch, Matt" <Matt_Domsch@dell.com>,
"Hargrave, Jordan" <Jordan_Hargrave@dell.com>,
"Rose, Charles" <Charles_Rose@dell.com>,
"Nijhawan, Vijay" <Vijay_Nijhawan@dell.com>
Subject: Re: [PATCH 1/2] Export firmware assigned labels of network devices
Date: Mon, 31 May 2010 14:07:56 +0000 [thread overview]
Message-ID: <1275314876.21246.29.camel@concordia> (raw)
In-Reply-To: <20100528115520.GA24114@littleblue.us.dell.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Fri, 2010-05-28 at 06:55 -0500, K, Narendra wrote:
> Hello,
>
> This patch is in continuation of an earlier discussion -
>
> http://marc.info/?l=linux-netdev&m=126712978908314&w=3
>
> The patch has the following review suggestions from the community incorporated -
>
> 1. The name of the attribute has been changed from "smbiosname" to "label" to hide
> the implementation details.
> 2. The implementation has been moved to a new file drivers/pci/pci-label.c
You've changed the name, which is good, but the implementation is still
100% dependant on ACPI or DMI AFAICS.
So it seems to me until it's supported on another platform it may as
well go in pci-acpi.c, or at least only be compiled if (ACPI || DMI).
Otherwise it's just dead code.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-05-31 14:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 11:55 [PATCH 1/2] Export firmware assigned labels of network devices to K, Narendra
2010-05-28 13:16 ` [PATCH 1/2] Export firmware assigned labels of network devices Domsch, Matt
2010-05-28 15:40 ` Greg KH
2010-05-28 18:11 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Matt Domsch
2010-05-28 22:27 ` [PATCH 1/2] Export firmware assigned labels of network devices Greg KH
2010-05-29 4:51 ` Domsch, Matt
2010-06-09 4:17 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Matt Domsch
2010-06-09 15:02 ` [PATCH 1/2] Export firmware assigned labels of network devices Greg KH
2010-05-31 7:55 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra_K
2010-05-31 14:07 ` Michael Ellerman [this message]
2010-05-31 18:54 ` Narendra_K
2010-06-02 23:54 ` [PATCH 1/2] Export firmware assigned labels of network devices Michael Ellerman
[not found] <EDA0A4495861324DA2618B4C45DCB3EE612AB6@blrx3m08.blr.amer.dell.com>
2010-06-29 16:28 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra K
2010-06-30 15:42 ` [PATCH 1/2] Export firmware assigned labels of network devices Greg KH
[not found] <EDA0A4495861324DA2618B4C45DCB3EE612B1B@blrx3m08.blr.amer.dell.com>
2010-07-06 18:52 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra K
2010-07-06 23:22 ` [PATCH 1/2] Export firmware assigned labels of network devices Greg KH
[not found] <EDA0A4495861324DA2618B4C45DCB3EE612B27@blrx3m08.blr.amer.dell.com>
2010-07-07 17:48 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra K
2010-07-07 18:11 ` [PATCH 1/2] Export firmware assigned labels of network devices Greg KH
2010-07-07 18:35 ` Domsch, Matt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275314876.21246.29.camel@concordia \
--to=michael@ellerman.id.au \
--cc=Charles_Rose@dell.com \
--cc=Jordan_Hargrave@dell.com \
--cc=Matt_Domsch@dell.com \
--cc=Narendra_K@dell.com \
--cc=Vijay_Nijhawan@dell.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).