From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Date: Tue, 15 Jun 2010 10:07:24 +0000 Subject: Re: New rule for xD FTL driver Message-Id: <1276596444.16500.12.camel@dell15> List-Id: References: <1276347244.4481.15.camel@maxim-laptop> In-Reply-To: <1276347244.4481.15.camel@maxim-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Mon, 2010-06-14 at 20:19 -0700, Greg KH wrote: > On Tue, Jun 15, 2010 at 02:55:49AM +0300, Maxim Levitsky wrote: > > On Mon, 2010-06-14 at 09:46 -0700, Greg KH wrote: > > > On Sat, Jun 12, 2010 at 03:54:04PM +0300, Maxim Levitsky wrote: > > > > Hi, > > > > > > > > I have written a driver for xD card reader and xD/SmartMedia FTL that is > > > > usually mandatory to use with xD cards. > > > > > > > > I think this can be added to 80-drivers.rule > > > > SUBSYSTEM="mtd", RUN+="/sbin/modprobe sm_ftl" > > > > > > Why does this module not have the proper MODULE_DEVICE() or aliases in > > > it so that you don't have to manually load the module? This should not > > > need to be a udev rule. > > > > Well mtd system is not using bus model. > > Why not? It should be fixed to do so. Of course. But I currently try to avoid changes that will result in changes in areas I can't test. This is one magnitude harder work, and I don't yet feel confident doing so. > > > However a card needs to be probed (theoteticly) by several high-level > > FTL drivers to make one of them to bind to it. (In fact several can bind > > at same now, which is both bad and good feature). > > Then why would you write a rule to automatically load the module on the > system no matter what? > > > I understand that module can have aliases so it can bind to a bus. > > module aliases are used by modprobe to know what module to load when a > device is found on a bus. > > > Of course I can do a 'request_module', but I think it isn't nice thing > > to do. > > Agreed. But as it looks like you always want this module loaded, why > not just make it part of your mtd core? Maybe not statically linked in it, but I am not against making mtd core load all compiled FTL drivers as soon as an mtd device is registred. David Woodhouse, what do you think about that? Best regards, Maxim Levitsky