From: Michael Forney <mforney@mforney.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] Don't install systemd scripts with --without-systemdsystemunitdir
Date: Thu, 02 Sep 2010 05:43:46 +0000 [thread overview]
Message-ID: <1283404668-sup-8933@mforney.org> (raw)
In-Reply-To: <1282875003-11074-1-git-send-email-mforney@mforney.org>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
Excerpts from Martin Pitt's message of Mon Aug 30 23:58:47 -0700 2010:
> Hello Michael,
>
> Michael Forney [2010-08-26 19:10 -0700]:
> > Currently, the scripts get installed to /no/ if that option is
> > specified.
>
> I can't reproduce this: I tried
>
> ./configure --prefix=/usr --without-systemdsystemunitdir
> make
> make install DESTDIR=/tmp/x/
>
> and I don't get a /tmp/x/no, nor does grepping for SYSTEMD reveal any
> assignment to "no".
>
> What's the particular configure command you are using?
>
> Martin
Hi Martin,
I am not sure why you are having trouble reproducing it. I ran the same
commands and still saw the issue I described. I have attached a log for
reference.
Logically though, what is happening is when
--without-systemdsystemunitdir gets passed to configure,
with_systemdsystemunitdir gets assigned the value 'no'. Configure then
checks if this string is non-zero (which it is), and enables
WITH_SYSTEMD. This causes the scripts to get installed to the directory
$(systemdsystemunitdir) which is 'no'.
This seems to be a problem with several projects using this option,
including NetworkManager, which has been fixed
(https://bugzilla.gnome.org/show_bug.cgi?id=628439), and dbus, which has
been not yet commented on
(https://bugs.freedesktop.org/attachment.cgi?id=38319).
I just tested this with master and I still see the problem. Are you sure
your build directory is clean?
Thanks for taking the time to look at my patch!
--
Michael Forney <mforney@mforney.org>
[-- Attachment #2: udev.log --]
[-- Type: application/octet-stream, Size: 29356 bytes --]
next prev parent reply other threads:[~2010-09-02 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 2:10 [PATCH] Don't install systemd scripts with --without-systemdsystemunitdir Michael Forney
2010-08-31 6:58 ` [PATCH] Don't install systemd scripts with Martin Pitt
2010-09-02 5:43 ` Michael Forney [this message]
2010-09-02 6:59 ` Martin Pitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283404668-sup-8933@mforney.org \
--to=mforney@mforney.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).