Re: [PATCH V4 1/2] tracing, perf : add cpu hotplug trace events

[Steven Rostedt <rostedt@goodmis.org>]

[ Added Ingo and Rusty ]

On Thu, 2011-02-24 at 15:26 +0100, Vincent Guittot wrote:
> Hi,
> 
> Any comments or feedbacks about these both patches ?

I'm fine with these patches and I believe Frederic said he was too. But
as these patches trace cpu hotplug, it is up to the maintainers of cpu
hotplug to make the final decision.

-- Steve

> 
> Thanks,
> Vincent
> 
> On 31 January 2011 11:22, Vincent Guittot <vincent.guittot@linaro.org> wrote:
> > Please find below a new proposal for adding trace events for cpu hotplug.
> > The goal is to measure the latency of each part (kernel, architecture)
> > and also to trace the cpu hotplug activity with other power events. I
> > have tested these traces events on an arm platform.
> >
> > Subject: [PATCH 1/2] cpu hotplug tracepoint
> >
> > this patch adds new events for cpu hotplug tracing
> >  * plug/unplug sequence
> >  * core and architecture latency measurements
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> > ---
> >  include/trace/events/cpu_hotplug.h |  103 ++++++++++++++++++++++++++++++++++++
> >  1 files changed, 103 insertions(+), 0 deletions(-)
> >  create mode 100644 include/trace/events/cpu_hotplug.h
> >
> > diff --git a/include/trace/events/cpu_hotplug.h
> > b/include/trace/events/cpu_hotplug.h
> > new file mode 100644
> > index 0000000..af05775
> > --- /dev/null
> > +++ b/include/trace/events/cpu_hotplug.h
> > @@ -0,0 +1,103 @@
> > +#undef TRACE_SYSTEM
> > +#define TRACE_SYSTEM cpu_hotplug
> > +
> > +#if !defined(_TRACE_CPU_HOTPLUG_H) || defined(TRACE_HEADER_MULTI_READ)
> > +#define _TRACE_CPU_HOTPLUG_H
> > +
> > +#include <linux/tracepoint.h>
> > +
> > +DECLARE_EVENT_CLASS(cpu_hotplug,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid),
> > +
> > +       TP_STRUCT__entry(
> > +               __field(        unsigned int,   cpuid   )
> > +       ),
> > +
> > +       TP_fast_assign(
> > +               __entry->cpuid = cpuid;
> > +       ),
> > +
> > +       TP_printk("cpuid=%u", __entry->cpuid)
> > +);
> > +
> > +/* Core function of cpu hotplug */
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_down_start,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_down_end,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_up_start,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_up_end,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +/* Architecture function for cpu hotplug */
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_disable_start,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_disable_end,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_die_start,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_die_end,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_arch_up_start,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_arch_up_end,
> > +
> > +       TP_PROTO(unsigned int cpuid),
> > +
> > +       TP_ARGS(cpuid)
> > +);
> > +
> > +#endif /* _TRACE_CPU_HOTPLUG_H */
> > +
> > +/* This part must be outside protection */
> > +#include <trace/define_trace.h>
> > --
> > 1.7.1
> >