From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Tejun Heo <tj@kernel.org>,
linux-scsi@vger.kernel.org, maggu2810@googlemail.com,
linux-hotplug@vger.kernel.org
Subject: Re: [PATCH SCSI] sr: check_events() ignore GET_EVENT when TUR says
Date: Wed, 20 Jul 2011 16:45:16 +0000 [thread overview]
Message-ID: <1311180316.8570.1.camel@mulgrave> (raw)
In-Reply-To: <CAPXgP11R=386wbqpOpymzdXYYhpvJg9Aj1Xck3wi91smud-8iA@mail.gmail.com>
On Wed, 2011-07-20 at 18:42 +0200, Kay Sievers wrote:
> On Wed, Jul 20, 2011 at 18:33, Tejun Heo <tj@kernel.org> wrote:
> > On Thu, Jun 30, 2011 at 03:03:48PM +0200, Tejun Heo wrote:
> >> From: Kay Sievers <kay.sievers@vrfy.org>
> >>
> >> Some broken devices indicates that media has changed on every
> >> GET_EVENT_STATUS_NOTIFICATION. This translates into MEDIA_CHANGE
> >> uevent on every open() which lets udev run into a loop.
> >>
> >> Verify GET_EVENT result against TUR and if it generates spurious
> >> events for several times in a row, ignore the GET_EVENT events, and
> >> trust only the TUR status.
>
> > James, ping.
>
> This is a rather urgent fix, that needs to go in, and also to -stable.
>
> Systems run into endless loops with ever-growing event queues. Nothing
> really works any more if we hit that condition, unless the (broken)
> device is disconnected.
Sorry ... I have it marked for inclusion in my internal queue, I'm just
having difficulty finding time to do a dump from queue and test. I
should be able to get all the fixes sorted on the 'plane home tomorrow.
James
next prev parent reply other threads:[~2011-07-20 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 13:03 [PATCH SCSI] sr: check_events() ignore GET_EVENT when TUR says Tejun Heo
2011-07-20 16:33 ` Tejun Heo
2011-07-20 16:42 ` [PATCH SCSI] sr: check_events() ignore GET_EVENT when TUR says otherwise Kay Sievers
2011-07-20 16:45 ` James Bottomley [this message]
2012-07-30 19:06 ` Markus Rathgeb
2012-07-30 19:41 ` Kay Sievers
2012-07-30 20:28 ` Markus Rathgeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311180316.8570.1.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maggu2810@googlemail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).