[PATCH V2] rules: Limit USB autosuspend on USB HID devices

[PATCH V2] rules: Limit USB autosuspend on USB HID devices

[Matthew Garrett]

Some USB ports on external hubs may be reported as "fixed". We only want
to auto-enable this on ports that are internal to the machine, so check
the parent state as well.
---

Sorry, screwed up the label name on the first version.

 rules/42-usb-hid-pm.rules |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/rules/42-usb-hid-pm.rules b/rules/42-usb-hid-pm.rules
index d5d5897..9e5f59f 100644
--- a/rules/42-usb-hid-pm.rules
+++ b/rules/42-usb-hid-pm.rules
@@ -46,4 +46,10 @@ ACTION="add", SUBSYSTEM="usb", ATTRS{idVendor}="04b3", ATTR{idProduct}="4012
 ACTION="add", SUBSYSTEM="usb", ATTR{idVendor}="14dd", ATTR{idProduct}="0002", TEST="power/control", ATTR{power/control}="auto"
 
 # USB HID devices that are internal to the machine should also be safe to autosuspend
+
+ACTION="add", SUBSYSTEM="usb", SUBSYSTEMS="usb", ATTRS{removable}="removable", GOTO="usb_hid_pm_end"
+ACTION="add", SUBSYSTEM="usb", SUBSYSTEMS="usb", ATTRS{removable}="unknown", GOTO="usb_hid_pm_end"        
+
 ACTION="add", SUBSYSTEM="usb", ATTR{bInterfaceClass}="03", ATTRS{removable}="fixed", TEST="../power/control", ATTR{../power/control}="auto"
+
+LABEL="usb_hid_pm_end"
\ No newline at end of file
-- 
1.7.10.2

Re: [PATCH V2] rules: Limit USB autosuspend on USB HID devices

[Kay Sievers]

On Fri, May 25, 2012 at 4:27 PM, Matthew Garrett <mjg@redhat.com> wrote:
> Some USB ports on external hubs may be reported as "fixed". We only want
> to auto-enable this on ports that are internal to the machine, so check
> the parent state as well.

>  rules/42-usb-hid-pm.rules |    6 ++++++
>  1 file changed, 6 insertions(+)

Applied.

Thanks,
Kay