From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lauri Kasanen Date: Sun, 03 Jun 2012 15:28:08 +0000 Subject: [PATCH] udev: Lower the starting children_max -> drop the minimum required RAM from 23mb to 5mb Message-Id: <1338737288.24120.140661084367789.5D16C15D@webmail.messagingengine.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="_----------=_1338737288241200" List-Id: To: linux-hotplug@vger.kernel.org This is a multi-part message in MIME format. --_----------=_1338737288241200 Content-Transfer-Encoding: 7bit Content-Type: text/plain Hi all Udev was the limiting factor for us on low-RAM systems. Given an average RSS of 180kb, 128 workers would require ~23mb of RAM. Now, please consider what happens when there is only, say, 15mb free. Udev protects itself from OOM, and the kernel can do nothing but panic. 28 workers * 0.18mb = ~5mb. This change should not affect more powerful systems much, given that they still get the addition from the amount of RAM. PS: Please CC me. Signed-off-by: Lauri Kasanen --- src/udev/udevd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 7905310..229031c 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -1353,9 +1353,9 @@ int main(int argc, char *argv[]) /* set value depending on the amount of RAM */ if (memsize > 0) - children_max = 128 + (memsize / 8); + children_max = 28 + (memsize / 8); else - children_max = 128; + children_max = 28; } log_debug("set children_max to %u\n", children_max); -- 1.7.2.1 -- http://www.fastmail.fm - The professional email service --_----------=_1338737288241200 Content-Disposition: attachment; filename="0001-udev-Lower-the-starting-children_max-drop-the-minimu.patch" Content-Id: <1338736984.23323.71c1a3e83f7cba0d272b1d7d5285cd7305f85a31@messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="0001-udev-Lower-the-starting-children_max-drop-the-minimu.patch" RnJvbSBmMDhhNTRiZDZiMzlkNDQ4NzAyZDhkY2JjNTk5MTBmZWE0MTljNDU2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyaSBLYXNhbmVu IDxjdXJhZ2FAb3BlcmFtYWlsLmNvbT4KRGF0ZTogU3VuLCAzIEp1biAyMDEy IDE4OjExOjU4ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gdWRldjogTG93ZXIg dGhlIHN0YXJ0aW5nIGNoaWxkcmVuX21heCAtPiBkcm9wIHRoZSBtaW5pbXVt IHJlcXVpcmVkIFJBTSBmcm9tIDIzbWIgdG8gNW1iCgpVZGV2IHdhcyB0aGUg bGltaXRpbmcgZmFjdG9yIGZvciB1cyBvbiBsb3ctUkFNIHN5c3RlbXMuCkdp dmVuIGFuIGF2ZXJhZ2UgUlNTIG9mIDE4MGtiLCAxMjggd29ya2VycyB3b3Vs ZCByZXF1aXJlIH4yM21iIG9mIFJBTS4KCk5vdywgcGxlYXNlIGNvbnNpZGVy IHdoYXQgaGFwcGVucyB3aGVuIHRoZXJlIGlzIG9ubHksIHNheSwgMTVtYiBm cmVlLgpVZGV2IHByb3RlY3RzIGl0c2VsZiBmcm9tIE9PTSwgYW5kIHRoZSBr ZXJuZWwgY2FuIGRvIG5vdGhpbmcgYnV0IHBhbmljLgoKMjggd29ya2VycyAq IDAuMThtYiA9IH41bWIuIFRoaXMgY2hhbmdlIHNob3VsZCBub3QgYWZmZWN0 IG1vcmUgcG93ZXJmdWwKc3lzdGVtcyBtdWNoLCBnaXZlbiB0aGF0IHRoZXkg c3RpbGwgZ2V0IHRoZSBhZGRpdGlvbiBmcm9tIHRoZSBhbW91bnQgb2YgUkFN LgoKU2lnbmVkLW9mZi1ieTogTGF1cmkgS2FzYW5lbiA8Y3VyYWdhQG9wZXJh bWFpbC5jb20+Ci0tLQogc3JjL3VkZXYvdWRldmQuYyB8ICAgIDQgKystLQog MSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3VkZXYvdWRldmQuYyBiL3NyYy91ZGV2 L3VkZXZkLmMKaW5kZXggNzkwNTMxMC4uMjI5MDMxYyAxMDA2NDQKLS0tIGEv c3JjL3VkZXYvdWRldmQuYworKysgYi9zcmMvdWRldi91ZGV2ZC5jCkBAIC0x MzUzLDkgKzEzNTMsOSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJn dltdKQogCiAgICAgICAgICAgICAgICAgLyogc2V0IHZhbHVlIGRlcGVuZGlu ZyBvbiB0aGUgYW1vdW50IG9mIFJBTSAqLwogICAgICAgICAgICAgICAgIGlm IChtZW1zaXplID4gMCkKLSAgICAgICAgICAgICAgICAgICAgICAgIGNoaWxk cmVuX21heCA9IDEyOCArIChtZW1zaXplIC8gOCk7CisgICAgICAgICAgICAg ICAgICAgICAgICBjaGlsZHJlbl9tYXggPSAyOCArIChtZW1zaXplIC8gOCk7 CiAgICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICAg ICAgY2hpbGRyZW5fbWF4ID0gMTI4OworICAgICAgICAgICAgICAgICAgICAg ICAgY2hpbGRyZW5fbWF4ID0gMjg7CiAgICAgICAgIH0KICAgICAgICAgbG9n X2RlYnVnKCJzZXQgY2hpbGRyZW5fbWF4IHRvICV1XG4iLCBjaGlsZHJlbl9t YXgpOwogCi0tIAoxLjcuMi4xCgo= --_----------=_1338737288241200--