From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Date: Mon, 17 Aug 2015 03:19:04 +0000 Subject: [Patch V3 7/9] x86, numa: Kill useless code to improve code readability Message-Id: <1439781546-7217-8-git-send-email-jiang.liu@linux.intel.com> List-Id: References: <1439781546-7217-1-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1439781546-7217-1-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Tang Chen , Tejun Heo , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Xishi Qiu , Jiang Liu , Luiz Capitulino , Dave Young Cc: Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org According to x86 boot sequence, early_cpu_to_node() always returns NUMA_NO_NODE when called from numa_init(). So kill useless code to improve code readability. Related code sequence as below: x86_cpu_to_node_map is set until step 2, so it is still the default value (NUMA_NO_NODE) when accessed at step 1. start_kernel() setup_arch() initmem_init() x86_numa_init() numa_init() early_cpu_to_node() 1) return early_per_cpu_ptr(x86_cpu_to_node_map)[cpu]; acpi_boot_init(); sfi_init() x86_dtb_init() generic_processor_info() early_per_cpu(x86_cpu_to_apicid, cpu) = apicid; init_cpu_to_node() numa_set_node(cpu, node); 2) per_cpu(x86_cpu_to_node_map, cpu) = node; rest_init() kernel_init() smp_init() native_cpu_up() start_secondary() numa_set_node() per_cpu(x86_cpu_to_node_map, cpu) = node; Signed-off-by: Jiang Liu --- arch/x86/mm/numa.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c index 4053bb58bf92..08860bdf5744 100644 --- a/arch/x86/mm/numa.c +++ b/arch/x86/mm/numa.c @@ -591,8 +591,6 @@ static void __init numa_init_array(void) rr = first_node(node_online_map); for (i = 0; i < nr_cpu_ids; i++) { - if (early_cpu_to_node(i) != NUMA_NO_NODE) - continue; numa_set_node(i, rr); rr = next_node(rr, node_online_map); if (rr = MAX_NUMNODES) @@ -644,14 +642,6 @@ static int __init numa_init(int (*init_func)(void)) if (ret < 0) return ret; - for (i = 0; i < nr_cpu_ids; i++) { - int nid = early_cpu_to_node(i); - - if (nid = NUMA_NO_NODE) - continue; - if (!node_online(nid)) - numa_clear_node(i); - } numa_init_array(); return 0; -- 1.7.10.4