From: "Martin Schwenke" <martin@meltin.net>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] namedev.c %c{N+} capability + buglet with SYMLINK
Date: Mon, 08 Mar 2004 05:02:52 +0000 [thread overview]
Message-ID: <16459.65148.50435.650308@martins.ozlabs.org> (raw)
In-Reply-To: <16459.53560.188318.971393@martins.ozlabs.org>
>>>>> "Kay" = Kay Sievers <kay.sievers@vrfy.org> writes:
Kay> Nice idea, but the code you've patched is gone:
Kay> http://linuxusb.bkbits.net:8080/udev/anno/namedev.c@1.125?nav=index.html|src/
Good! :-)
Kay> Hey, it was too ugly and you try to make it more ugly :)
Yep, I was trying for the most compact patch, without trying to change
the style of the existing code...
Kay> Here is a patch for the current version, but there are more
Kay> patches pending and we need to change it again.
... and the new code is much more elegant, which is shown by the fact
that the feature I want can be slotted in so nicely... :-)
2 questions:
* Can '\t' please be a separator too?
* Can we please merge your '+' patch?
Now, about that other bit:
Martin> PROGRAM="/sbin/aliaser %b %k %n %M %m", RESULT="?*", NAME="%c{1}", SYMLINK="%c{2+}"
Martin> [...]
Martin> The only gotcha is that the rule won't apply when SYMLINK
Martin> gets an empty value (that is, there is only 1 word). This
Martin> seems kind-of broken, since it stops you using a general
Martin> rule to do the symlinks, and I think the semantics of an
Martin> empty SYMLINK value are pretty clear (i.e. no symlinks
Martin> please).
Looking at namedev.c and udev-add.c, I can't see why SYMLINK
(dev->symlink, udev->symlink) being set to empty would stop the node
for NAME being created, but that does seem to be the case.
Any ideas?
Thanks...
peace & happiness,
martin
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-03-08 5:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 1:49 [PATCH] namedev.c %c{N+} capability + buglet with SYMLINK Martin Schwenke
2004-03-08 2:44 ` Kay Sievers
2004-03-08 5:02 ` Martin Schwenke [this message]
2004-03-08 13:04 ` Kay Sievers
2004-03-09 4:37 ` Martin Schwenke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16459.65148.50435.650308@martins.ozlabs.org \
--to=martin@meltin.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).