Re: udev - Shouldn't we blacklist some devices?

[Kay Sievers <kay.sievers@vrfy.org>]

On Sun, Jan 04, 2004 at 12:42:04AM +0100, Kay Sievers wrote:
> On Sat, Jan 03, 2004 at 03:31:49PM -0800, Greg KH wrote:
> > On Sun, Jan 04, 2004 at 12:07:21AM +0100, Kay Sievers wrote:
> > > On Sat, Jan 03, 2004 at 01:48:57PM -0800, Greg KH wrote:
> > > > On Sat, Jan 03, 2004 at 09:07:53PM +0100, Kay Sievers wrote:
> > > > > While connecting my flash reader to the USB bus I get:
> > > > > 
> > > > > Jan  3 20:56:58 pim udev[31673]: sleep_for_dev: looking for '/sys/class/scsi_device/54:0:0:2/dev'
> > > > > Jan  3 20:56:59 pim udev[31695]: sleep_for_dev: looking for '/sys/class/scsi_device/54:0:0:3/dev'
> > > > > Jan  3 20:56:59 pim udev[31514]: sleep_for_dev: looking for '/sys/class/scsi_host/host54/dev'
> > > > > 
> > > > > Shouldn't we blacklist devices like  /sys/class/scsi_device/*, /sys/class/scsi_host/* ?
> > > > 
> > > > Yes we should, as we try to remove those device nodes when the devices
> > > > get removed (look for the 'trying to remove host54' messages), which
> > > > could be very dangerous.
> > > > 
> > > 
> > > So, here we go:
> > > 
> > > Blacklist devices that we don't want to process, like:
> > > /sys/class/scsi_device/*, /sys/class/scsi_host/*,
> > > cause these devices are handled by the block device events we receive
> > > and we don't try to remove non existing nodes.
> > 
> > How about this patch instead (not tested)?  It removes the explicit test
> > for net class devices.
> 
> Nice, looks good.
> I've tested it:
> 
> Jan  4 00:38:40 pim udev[4389]: udev_hotplug: looking at '/class/scsi_device/62:0:0:0'
> Jan  4 00:38:40 pim udev[4389]: udev_hotplug: don't care about 'scsi_device' devices
> 
> Jan  4 00:38:41 pim udev[4562]: udev_hotplug: looking at '/class/scsi_host/host62'
> Jan  4 00:38:41 pim udev[4562]: udev_hotplug: don't care about 'scsi_host' devices

Oh, my testing is good, but reading to the end of the debug is better :)
It should be:
  if (strcmp(subsystem, subsystem_blacklist[i]) = 0) {

otherwise we skip everything.

Kay


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id\x1278&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel