From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Hicks Date: Tue, 13 Jan 2004 19:27:23 +0000 Subject: Re: [PATCH] udev - small script optimization Message-Id: <20040113192723.GG30627@localhost> List-Id: References: <20040113035015.GA9989@vrfy.org> In-Reply-To: <20040113035015.GA9989@vrfy.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Jan 13, 2004 at 04:50:15AM +0100, Kay Sievers wrote: > > The name_cdrom.pl is only executed for ide and scsi devices, but not for a partition. > It exits with nonzero to skip the rule if the CD is not found: > > KERNEL="[hs]d[a-z]", PROGRAM="name_cdrom.pl %M %m", NAME="%1c", SYMLINK="cdrom" > This won't work on machines with lots of SCSI targets (I suppose IDE could have the same problem although it's much less likely) I'm pretty sure that we don't support the '+' metacharacter, but what would really work is: KERNEL="[hs]d[a-z]+" because after sdz we go on to sdaa. I'm not really complaining, because it seems unlikely that you would find machines with cdroms after the first 26 SCSI targets. I'm just pointing out that this rule isn't exactly correct. mh -- Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE ------------------------------------------------------- This SF.net email is sponsored by: Perforce Software. Perforce is the Fast Software Configuration Management System offering advanced branching capabilities and atomic changes on 50+ platforms. Free Eval! http://www.perforce.com/perforce/loadprog.html _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel