From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] set default owner/group in db.
Date: Fri, 16 Jan 2004 22:51:00 +0000 [thread overview]
Message-ID: <20040116225100.GB3263@kroah.com> (raw)
In-Reply-To: <32230000.1074291692@w-hlinder>
On Fri, Jan 16, 2004 at 02:21:32PM -0800, Hanna Linder wrote:
>
> This patch fixes a bug where the udev database stored empty strings
> for Owner and Group if they were default. This patch stores the default
> value into the database if not set otherwise. See example output:
>
>
> crw------- 1 root root 4, 65 Jan 16 11:13 ttyS1
>
> P: /class/tty/ttyS1
> N: ttyS1
> S:
> O: root
> G: root
>
> This is a bit of a hack. However, until udev supports setting the
> o/g values they will be root/root anyway so the database might as
> well reflect the truth instead of empty strings.
Hm, in thinking about this some more, how about just adding support for
a default owner and default group to the main udev.config file? Then
your patch here would turn into something like:
> diff -Nru a/namedev.c b/namedev.c
> --- a/namedev.c Fri Jan 16 15:18:18 2004
> +++ b/namedev.c Fri Jan 16 15:18:18 2004
> @@ -720,8 +720,8 @@
> } else {
> /* no matching perms found :( */
> udev->mode = get_default_mode(class_dev);
> - udev->owner[0] = 0x00;
> - udev->group[0] = 0x00;
> + udev->owner[0] = get_default_owner(class_dev);
> + udev->group[0] = get_default_group(class_dev);
> }
> dbg("name, '%s' is going to have owner='%s', group='%s', mode = %#o",
> udev->name, udev->owner, udev->group, udev->mode);
That way the owner and group would end up in the database properly.
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-01-16 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-16 22:21 [PATCH] set default owner/group in db Hanna Linder
2004-01-16 22:51 ` Greg KH [this message]
2004-01-17 1:10 ` Hanna Linder
2004-01-17 1:33 ` Hanna Linder
2004-01-17 15:12 ` Kay Sievers
2004-01-19 18:41 ` Hanna Linder
2004-01-19 19:44 ` Greg KH
2004-01-19 19:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116225100.GB3263@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).