Re: [ANNOUNCE] udev 013 release

[Greg KH <greg@kroah.com>]

On Mon, Jan 19, 2004 at 09:29:00PM +0100, Olaf Hering wrote:
>  On Thu, Jan 15, Kay Sievers wrote:
> 
> > +++ b/logging.h	Thu Jan 15 15:22:25 2004
> 
> > +#ifdef LOG
> > +#include <syslog.h>
> 
> > +#ifdef DEBUG
> > +#define dbg(format, arg...)								\
> > +	do {										\
> > +		log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg);	\
> 
> This breaks with:
> 
>  make udevdir=/dev USE_LOGúlse USE_KLIBC=true DEBUG=true STRIP=/bin/true -j
> 
> syslog.h does not depend on -DLOG

Ick.  This patch should fix this problem.

If you make USE_LOGúlse, no debug messages will be sent out.

thanks,

greg k-h


=== logging.h 1.2 vs edited ==--- 1.2/logging.h	Thu Jan 15 14:00:58 2004
+++ edited/logging.h	Mon Jan 19 12:37:42 2004
@@ -24,35 +24,37 @@
 #ifndef LOGGING_H
 #define LOGGING_H
 
+#define info(format, arg...)		do { } while (0)
+#define dbg(format, arg...)		do { } while (0)
+#define dbg_parse(format, arg...)	do { } while (0)
+
 #ifdef LOG
 #include <syslog.h>
+
+#undef info
 #define info(format, arg...)								\
 	do {										\
 		log_message (LOG_INFO , format , ## arg);	\
 	} while (0)
-#else
-	#define info(format, arg...) do { } while (0)
-#endif
 
 #ifdef DEBUG
+#undef dbg
 #define dbg(format, arg...)								\
 	do {										\
 		log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg);	\
 	} while (0)
-#else
-	#define dbg(format, arg...) do { } while (0)
 #endif
 
 /* Parser needs it's own debugging statement, we usually don't care about this at all */
 #ifdef DEBUG_PARSER
+#undef dbg_parse
 #define dbg_parse(format, arg...)							\
 	do {										\
 		log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg);	\
 	} while (0)
-#else
-	#define dbg_parse(format, arg...) do { } while (0)
 #endif
 
+#endif	/* LOG */
 
 extern int log_message (int level, const char *format, ...)
 	__attribute__ ((format (printf, 2, 3)));


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel