From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 19 Jan 2004 20:40:17 +0000 Subject: Re: [ANNOUNCE] udev 013 release Message-Id: <20040119204017.GJ3896@kroah.com> List-Id: References: <20040113235213.GA7659@kroah.com> In-Reply-To: <20040113235213.GA7659@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org On Mon, Jan 19, 2004 at 09:29:00PM +0100, Olaf Hering wrote: > On Thu, Jan 15, Kay Sievers wrote: >=20 > > +++ b/logging.h Thu Jan 15 15:22:25 2004 >=20 > > +#ifdef LOG > > +#include >=20 > > +#ifdef DEBUG > > +#define dbg(format, arg...) \ > > + do { \ > > + log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg); \ >=20 > This breaks with: >=20 > make udevdir=3D/dev USE_LOG=FAlse USE_KLIBC=3Dtrue DEBUG=3Dtrue STRIP=3D= /bin/true -j >=20 > syslog.h does not depend on -DLOG Ick. This patch should fix this problem. If you make USE_LOG=FAlse, no debug messages will be sent out. thanks, greg k-h =3D=3D=3D logging.h 1.2 vs edited =3D=3D--- 1.2/logging.h Thu Jan 15 14:00:= 58 2004 +++ edited/logging.h Mon Jan 19 12:37:42 2004 @@ -24,35 +24,37 @@ #ifndef LOGGING_H #define LOGGING_H =20 +#define info(format, arg...) do { } while (0) +#define dbg(format, arg...) do { } while (0) +#define dbg_parse(format, arg...) do { } while (0) + #ifdef LOG #include + +#undef info #define info(format, arg...) \ do { \ log_message (LOG_INFO , format , ## arg); \ } while (0) -#else - #define info(format, arg...) do { } while (0) -#endif =20 #ifdef DEBUG +#undef dbg #define dbg(format, arg...) \ do { \ log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg); \ } while (0) -#else - #define dbg(format, arg...) do { } while (0) #endif =20 /* Parser needs it's own debugging statement, we usually don't care about = this at all */ #ifdef DEBUG_PARSER +#undef dbg_parse #define dbg_parse(format, arg...) \ do { \ log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg); \ } while (0) -#else - #define dbg_parse(format, arg...) do { } while (0) #endif =20 +#endif /* LOG */ =20 extern int log_message (int level, const char *format, ...) __attribute__ ((format (printf, 2, 3))); ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel