From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 19 Jan 2004 20:50:51 +0000 Subject: Re: [ANNOUNCE] udev 013 release Message-Id: <20040119205051.GA4317@kroah.com> List-Id: References: <20040113235213.GA7659@kroah.com> In-Reply-To: <20040113235213.GA7659@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org On Mon, Jan 19, 2004 at 09:44:15PM +0100, Olaf Hering wrote: > On Mon, Jan 19, Greg KH wrote: >=20 > > On Mon, Jan 19, 2004 at 09:29:00PM +0100, Olaf Hering wrote: > > > On Thu, Jan 15, Kay Sievers wrote: > > >=20 > > > > +++ b/logging.h Thu Jan 15 15:22:25 2004 > > >=20 > > > > +#ifdef LOG > > > > +#include > > >=20 > > > > +#ifdef DEBUG > > > > +#define dbg(format, arg...) \ > > > > + do { \ > > > > + log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg);= \ > > >=20 > > > This breaks with: > > >=20 > > > make udevdir=3D/dev USE_LOG=FAlse USE_KLIBC=3Dtrue DEBUG=3Dtrue STRI= P=3D/bin/true -j > > >=20 > > > syslog.h does not depend on -DLOG > >=20 > > Ick. This patch should fix this problem. > >=20 > > If you make USE_LOG=FAlse, no debug messages will be sent out. >=20 > Is this correct? LOG_DEBUG is defined in syslog.h, this patch is > probably better. Hm, but my patch will fix the problem when DEBUG=FAlse, yet someone goes and enables DEBUG_PARSER on their own. That always annoys me :) thanks, greg k-h ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel