From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 19 Jan 2004 21:41:38 +0000 Subject: Re: calling pci_find_device in interrupt ? Message-Id: <20040119214138.GF4407@kroah.com> List-Id: References: <20040119151531.C22416@forte.austin.ibm.com> In-Reply-To: <20040119151531.C22416@forte.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linas@austin.ibm.com Cc: linux-hotplug-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org On Mon, Jan 19, 2004 at 03:15:31PM -0600, linas@austin.ibm.com wrote: > > Greg, Hm, this isn't really a hotplug question. This is better asked on linux-kernel. > I was calling pci_find_device() from an interrupt, when I discovered > that it has a WARN_ON(in_interrupt()); in it. > > Why? If spin_lock(&pci_bus_lock); was changed to spin_lock_irqsave(), > it seems like it would be interrupt-safe. Because you should not call such a function from an interrupt. It is a waste of time. Just save off your pci device structure properly in your setup functions. Also, don't use the pci_find_* functions. Use the pci_get_* functions instead, as the pci_find_* functions will be going away in a future kernel version (probably 2.7). thanks, greg k-h ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel