* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
@ 2004-01-21 23:53 ` Greg KH
2004-01-22 0:40 `
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2004-01-21 23:53 UTC (permalink / raw)
To: linux-hotplug
On Tue, Jan 20, 2004 at 07:08:04PM +0100, Svetoslav Slavtchev wrote:
> Hi,
> the attached patch removes the need from a symbolik link to kernel headers
> when compiling against klibc.
> if KERNEL_DIR is not specified it looks for kernel headers
> in /usr/src/linux( of course you could change it to /lib/modules/`uname
> -r`/build )
It's a nice idea, but is it really needed?
No one should be putting their kernel code in /usr/src/linux, so that's
just a bad thing to start with. /usr/src/linux points to the version of
linux that your glibc was built against, that is all.
> the main idea is to build packages a bit easier/ pretier
> instead of creating a symbolik link, one can specify
> make KERNEL_DIR=[path to kernel] or omit it in case
> kernel sources are available in /usr/src/linux
Does the current situation really cause that much of a problem in
building packages?
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
2004-01-21 23:53 ` Greg KH
@ 2004-01-22 0:40 `
2004-01-22 1:51 `
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: @ 2004-01-22 0:40 UTC (permalink / raw)
To: linux-hotplug
Greg KH <greg@kroah.com> writes:
> No one should be putting their kernel code in /usr/src/linux, so that's
> just a bad thing to start with. /usr/src/linux points to the version of
> linux that your glibc was built against, that is all.
No, that's /usr/include/{linux,asm} you're thinking of. They should be
_copies_ of the kernel headers glibc was built against, and not symlinks
to /usr/src/linux/{include,asm}. /usr/src/linux can be whatever you
like, and third-party, out-of-three modules tend to look there (after
/lib/modules/$(uname -r)/build and /usr/src/linux-$(uname -r)) for the
current kernel headers.
--
ilmari
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
2004-01-21 23:53 ` Greg KH
2004-01-22 0:40 `
@ 2004-01-22 1:51 `
2004-01-22 3:42 ` Dave Dodge
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: @ 2004-01-22 1:51 UTC (permalink / raw)
To: linux-hotplug
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
> third-party, out-of-three modules
^^^^^
tree, obviously
--
ilmari
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
` (2 preceding siblings ...)
2004-01-22 1:51 `
@ 2004-01-22 3:42 ` Dave Dodge
2004-01-22 17:06 ` linas
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Dave Dodge @ 2004-01-22 3:42 UTC (permalink / raw)
To: linux-hotplug
On Thu, Jan 22, 2004 at 01:40:50AM +0100, Dagfinn Ilmari Manns?ker wrote:
> Greg KH <greg@kroah.com> writes:
> > No one should be putting their kernel code in /usr/src/linux, so that's
> > just a bad thing to start with. /usr/src/linux points to the version of
> > linux that your glibc was built against, that is all.
>
> No, that's /usr/include/{linux,asm} you're thinking of. They should be
> _copies_ of the kernel headers glibc was built against, and not symlinks
> to /usr/src/linux/{include,asm}. /usr/src/linux can be whatever you like,
True. But because of past misbehavior by distributions and glibc, leading
to the sort of confusion above about what might be found in /usr/src/linux,
you should really avoid using /usr/src/linux for anything at all.
Since at least early 2.4 the kernel README has explictly stated that
kernels should not be placed in /usr/src/linux.
> and third-party, out-of-tree modules tend to look there
I'm sure they do. But that doesn't mean they should :-)
-Dave Dodge
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
` (3 preceding siblings ...)
2004-01-22 3:42 ` Dave Dodge
@ 2004-01-22 17:06 ` linas
2004-01-22 17:24 ` Svetoslav Slavtchev
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: linas @ 2004-01-22 17:06 UTC (permalink / raw)
To: linux-hotplug
On Thu, Jan 22, 2004 at 02:51:29AM +0100, Dagfinn Ilmari Manns?ker wrote:
> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>
> > third-party, out-of-three modules
> ^^^^^
> tree, obviously
Oh, and I thought that was a witty way to say "three out of three
third parties" ...
I once used a third-party, proprietary ide driver (rocketraid 404)
that installed itself in /usr/src/linux instead of /lib/modules.
Then one day I rm -r'ed /usr/src/linux ... and never booted that
machine again.
--linas
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
` (4 preceding siblings ...)
2004-01-22 17:06 ` linas
@ 2004-01-22 17:24 ` Svetoslav Slavtchev
2004-01-22 17:28 ` Greg KH
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Svetoslav Slavtchev @ 2004-01-22 17:24 UTC (permalink / raw)
To: linux-hotplug
> On Tue, Jan 20, 2004 at 07:08:04PM +0100, Svetoslav Slavtchev wrote:
> > Hi,
> > the attached patch removes the need from a symbolik link to kernel
> headers
> > when compiling against klibc.
> > if KERNEL_DIR is not specified it looks for kernel headers
> > in /usr/src/linux( of course you could change it to /lib/modules/`uname
> > -r`/build )
>
> It's a nice idea, but is it really needed?
well, i could always patch it :-)
and may be other packagers too,
but i think it's a good idea
> No one should be putting their kernel code in /usr/src/linux, so that's
> just a bad thing to start with. /usr/src/linux points to the version of
> linux that your glibc was built against, that is all.
every distribution( at least the major ones) do have a package kernel source
which does install in /usr/src/linux-[version] and put's a symlink
/usr/src/linux
( and /lib/modules/`uname -r`) to it
from my experiance i can say this is true for Mandrake, RedHat, SuSE
and i think Debian too
and most if not all external modules do check for kernel headers
in the above locations( and not only modules, but also programs
e.g. iptables, dvb apps.)
> > the main idea is to build packages a bit easier/ pretier
> > instead of creating a symbolik link, one can specify
> > make KERNEL_DIR=[path to kernel] or omit it in case
> > kernel sources are available in /usr/src/linux
>
> Does the current situation really cause that much of a problem in
> building packages?
>
it's not a trouble, but IMHO it's a bit ugly to create symlink to kernel
source
in the package build
best,
svetljo
--
+++ GMX - die erste Adresse für Mail, Message, More +++
Bis 31.1.: TopMail + Digicam für nur 29 EUR http://www.gmx.net/topmail
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
` (5 preceding siblings ...)
2004-01-22 17:24 ` Svetoslav Slavtchev
@ 2004-01-22 17:28 ` Greg KH
2004-01-22 17:31 ` Greg KH
2004-02-03 0:52 ` Greg KH
8 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2004-01-22 17:28 UTC (permalink / raw)
To: linux-hotplug
On Thu, Jan 22, 2004 at 01:40:50AM +0100, Dagfinn Ilmari Mannsåker wrote:
> Greg KH <greg@kroah.com> writes:
>
> > No one should be putting their kernel code in /usr/src/linux, so that's
> > just a bad thing to start with. /usr/src/linux points to the version of
> > linux that your glibc was built against, that is all.
>
> No, that's /usr/include/{linux,asm} you're thinking of. They should be
> _copies_ of the kernel headers glibc was built against, and not symlinks
> to /usr/src/linux/{include,asm}.
Ah yes, you are correct. Got that mixed up...
> /usr/src/linux can be whatever you like, and third-party, out-of-three
> modules tend to look there (after /lib/modules/$(uname -r)/build and
> /usr/src/linux-$(uname -r)) for the current kernel headers.
But /lib/modules/`uname -r`/build is much better than defaulting to
/usr/src/linux
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
` (6 preceding siblings ...)
2004-01-22 17:28 ` Greg KH
@ 2004-01-22 17:31 ` Greg KH
2004-02-03 0:52 ` Greg KH
8 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2004-01-22 17:31 UTC (permalink / raw)
To: linux-hotplug
On Thu, Jan 22, 2004 at 06:24:02PM +0100, Svetoslav Slavtchev wrote:
> > On Tue, Jan 20, 2004 at 07:08:04PM +0100, Svetoslav Slavtchev wrote:
> > > Hi,
> > > the attached patch removes the need from a symbolik link to kernel
> > headers
> > > when compiling against klibc.
> > > if KERNEL_DIR is not specified it looks for kernel headers
> > > in /usr/src/linux( of course you could change it to /lib/modules/`uname
> > > -r`/build )
> >
> > It's a nice idea, but is it really needed?
>
> well, i could always patch it :-)
> and may be other packagers too,
> but i think it's a good idea
Ok, how about defaulting to /lib/modules/`uname -r`/build instead.
Also, you don't have to check if KERNEL_DIR is set before trying to set
it yourself. Make will handle this properly.
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PATCH: drop symbolink link to kernel headers
2004-01-20 18:08 PATCH: drop symbolink link to kernel headers Svetoslav Slavtchev
` (7 preceding siblings ...)
2004-01-22 17:31 ` Greg KH
@ 2004-02-03 0:52 ` Greg KH
8 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2004-02-03 0:52 UTC (permalink / raw)
To: linux-hotplug
On Tue, Jan 20, 2004 at 07:08:04PM +0100, Svetoslav Slavtchev wrote:
> Hi,
> the attached patch removes the need from a symbolik link to kernel headers
> when compiling against klibc.
> if KERNEL_DIR is not specified it looks for kernel headers
> in /usr/src/linux( of course you could change it to /lib/modules/`uname
> -r`/build )
>
> the main idea is to build packages a bit easier/ pretier
> instead of creating a symbolik link, one can specify
> make KERNEL_DIR=[path to kernel] or omit it in case
> kernel sources are available in /usr/src/linux
Ok, I've fixed up this patch, added documentation, and applied it.
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 10+ messages in thread