From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: match order in udev.permissions
Date: Thu, 12 Feb 2004 22:30:02 +0000 [thread overview]
Message-ID: <20040212223002.GA3878@kroah.com> (raw)
In-Reply-To: <20040129130405.GA2415@suse.de>
On Thu, Feb 12, 2004 at 11:19:15PM +0100, Kay Sievers wrote:
> On Thu, Feb 12, 2004 at 02:03:46PM -0800, Greg KH wrote:
> > On Thu, Jan 29, 2004 at 02:04:05PM +0100, Olaf Hering wrote:
> > >
> > > I have this stuff in udev.permissions, /dev/tty does not get 0666, but
> > > 0620 for some reason. Anyone else seeing this? version is 015.
> > >
> > > tty:root:tty:666
> > > tty[0-9][0-9]*:root:tty:666
> > > tty*:root:tty:620
> > > ttyH*:root:root:666
> > > ttyC*:root:root:666
> > > ttyD*:root:root:666
> > > ttyE*:root:root:666
> > > ttyX*:root:root:666
> > > ttyI*:root:uucp:660
> > > ttyR*:root:root:666
> > > ttyL*:root:root:666
> > > ttyW*:root:uucp:660
> > > ttyACM*:root:uucp:660
> > > ttyUSB*:root:uucp:660
> > > ttySL0*:root:uucp:660
> > > ttyUB*:root:uucp:660
> > >
> > > it seems tty[0-9][0-9]* does not match tty1. Should it?
> >
> > Hm, I think the following patch should fix this. Can you verify it?
>
> We are using shell style pattern matching, which isn't regex related.
> So tty[0-9][0-9]* will expect (tty)+(2 digits)+(anything or nothing).
>
> I did not test it, but I think only tty[0-9]* will match.
The bug is that we are doing matching when we put the permission rule in
our list of permissions. We shouldn't do that at all, but only check to
see if the rule is identical.
We do the pattern matching later when we evaluate the rules in the
find_perm() function.
thanks,
greg k-h
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2004-02-12 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-29 13:04 match order in udev.permissions Olaf Hering
2004-02-12 22:03 ` Greg KH
2004-02-12 22:19 ` Kay Sievers
2004-02-12 22:26 ` Olaf Hering
2004-02-12 22:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040212223002.GA3878@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).