From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Thu, 12 Feb 2004 22:30:02 +0000 Subject: Re: match order in udev.permissions Message-Id: <20040212223002.GA3878@kroah.com> List-Id: References: <20040129130405.GA2415@suse.de> In-Reply-To: <20040129130405.GA2415@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Thu, Feb 12, 2004 at 11:19:15PM +0100, Kay Sievers wrote: > On Thu, Feb 12, 2004 at 02:03:46PM -0800, Greg KH wrote: > > On Thu, Jan 29, 2004 at 02:04:05PM +0100, Olaf Hering wrote: > > > > > > I have this stuff in udev.permissions, /dev/tty does not get 0666, but > > > 0620 for some reason. Anyone else seeing this? version is 015. > > > > > > tty:root:tty:666 > > > tty[0-9][0-9]*:root:tty:666 > > > tty*:root:tty:620 > > > ttyH*:root:root:666 > > > ttyC*:root:root:666 > > > ttyD*:root:root:666 > > > ttyE*:root:root:666 > > > ttyX*:root:root:666 > > > ttyI*:root:uucp:660 > > > ttyR*:root:root:666 > > > ttyL*:root:root:666 > > > ttyW*:root:uucp:660 > > > ttyACM*:root:uucp:660 > > > ttyUSB*:root:uucp:660 > > > ttySL0*:root:uucp:660 > > > ttyUB*:root:uucp:660 > > > > > > it seems tty[0-9][0-9]* does not match tty1. Should it? > > > > Hm, I think the following patch should fix this. Can you verify it? > > We are using shell style pattern matching, which isn't regex related. > So tty[0-9][0-9]* will expect (tty)+(2 digits)+(anything or nothing). > > I did not test it, but I think only tty[0-9]* will match. The bug is that we are doing matching when we put the permission rule in our list of permissions. We shouldn't do that at all, but only check to see if the rule is identical. We do the pattern matching later when we evaluate the rules in the find_perm() function. thanks, greg k-h ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id56&alloc_id438&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel